1779001 - Tab previews are not displayed in the main window when hovered from the taskbar pin

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: Win Taskbar Preview.gif

Note

• This is a Windows specific issue.

Found in

• Firefox 103 beta 7

Affected versions

• Firefox 103 beta 7

Affected platforms

• Win 10 64-bit

Steps to reproduce

1. Go to about:preferences and enable Show tab previews in the Windows taskbar option from Tabs section
2. Open at least 3 websites in different tabs
3. Hover over the Firefox icon present on the taskbar - thumbnails for each open tab are shown as tabs preview
4. Hover over each thumbnail

Expected result

• The websites are shown in the main window

Actual result

• Firefox flashes each time a different thumbnail is hovered. Site previews are not shown on the main window

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7fff10da0dcc3b86295cceca28d5688d2ef093a2&tochange=abb3901bfacab22f0f3f97b659f220c16fcd14ce
• Potentially regressed by: bug 1753995

Comment 1

[Donal Meehan [:dmeehan]]

:emilio potentially regressed by bug 1753995? If you could take a look?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1779001 - Fix WindowsPreviewerPerTab scale computation. r=Gijs,mconley

Seems this code has ~0 tests :-(

It also seems to have a dpi issue but that is pre-existing (tab contents look
blurry), but that's pre-existing.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1753995

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3dc5d3269c7
Fix WindowsPreviewerPerTab scale computation. r=Gijs

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f3dc5d3269c7

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Firefox 104 beta 5, Win 10 64-bit.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR102 approval when you get a chance.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9285166 [details]
Bug 1779001 - Fix WindowsPreviewerPerTab scale computation. r=Gijs,mconley

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes regression from 99, one-liner.
• User impact if declined: comment 0
• Fix Landed on Version: 104
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9285166 [details]
Bug 1779001 - Fix WindowsPreviewerPerTab scale computation. r=Gijs,mconley

Approved for 102.2esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/f2e8994452dd

Comment 11

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 102.2.0esr (20220815170108) on Windows 10 x64.