Closed Bug 1779031 Opened 3 years ago Closed 3 years ago

Remove about plugins from help menu

Categories

(SeaMonkey :: General, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Future
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

Details

(Whiteboard: SM2.53.14)

Attachments

(2 files, 1 obsolete file)

About plugins is basically useless right now until/if we enable drm support. As suggest add a link to the build configuration instaed.

Attached patch 1779031-buildconfig-25314.patch (obsolete) — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): NPAPI removal
User impact if declined: Useless menu point
Testing completed (on m-c, etc.): 2.53.14
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: menu description and access key plus removal.

Attachment #9284971 - Flags: review?(iannbugzilla)
Attachment #9284971 - Flags: approval-comm-release?

Comment on attachment 9284971 [details] [diff] [review]
1779031-buildconfig-25314.patch

If we are adding it to the About menu, then we should probably remove it from the Debug menu.

Flags: needinfo?(frgrahl)
Attachment #9284971 - Flags: review?(iannbugzilla)
Attachment #9284971 - Flags: approval-comm-release?

Same patch as before but used Show build configuration as imenu text from debugQA
[Approval Request Comment]
Regression caused by (bug #): NPAPI removal
User impact if declined: -- Useless menu
Testing completed (on m-c, etc.): 2.53.14
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch:

Flags: needinfo?(frgrahl)
Attachment #9285010 - Flags: review?(iannbugzilla)
Attachment #9285010 - Flags: approval-comm-release?
Attachment #9284971 - Attachment is obsolete: true

Remove Show bvuild configuration from debugQA after moving it to help. Version not adjusted. Can land together with Bug 1779028.

Attachment #9285011 - Flags: review?(iannbugzilla)
Attachment #9285011 - Flags: approval-comm-release?

Comment on attachment 9285010 [details] [diff] [review]
1779031-buildconfig-25314.patch

[Triage Comment]
LGTM r/a=me

Attachment #9285010 - Flags: review?(iannbugzilla)
Attachment #9285010 - Flags: review+
Attachment #9285010 - Flags: approval-comm-release?
Attachment #9285010 - Flags: approval-comm-release+

Comment on attachment 9285011 [details] [diff] [review]
1779031-2-buildconfig-25314.patch

[Triage Comment]
LGTM r/a=me

Attachment #9285011 - Flags: review?(iannbugzilla)
Attachment #9285011 - Flags: review+
Attachment #9285011 - Flags: approval-comm-release?
Attachment #9285011 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/358c0ac38224
Replace about:plugins with about:buildconfig in the help menu. r=IanN
https://hg.mozilla.org/comm-central/rev/11e36f96cfc4
Remove show build configuration from debugQA. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Future
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: