1779144 - Handle tap gesture blocks in APZCTreeManager::ConvertToGecko()

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

APZCTreeManager::ConvertToGecko(), used during the APZ handling of tap gesture events, assumes the tap gesture events were gesture-detected from touch events and therefore we're in the middle of a touch gesture, and accordingly looks at mTouchBlockHitResult.

However, since we implemented touchpad double-tap-to-zoom, tap gesture events can also be sent directly by the widget code. To handle them properly in ConvertToGecko(), we should maintain a "tap gesture hit result" and use it instead of mTouchBlockHitResult when applicable.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1779144 - Handle touchpad double-taps correctly in APZCTreeManager::ConvertToGecko(). r=dlrobertson

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1779144 - Factor out a helper shared by the touch event and tap event handling codepaths. r=dlrobertson

Depends on D151939

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1779144 - Handle touchpad double-taps correctly in APZCTreeManager::ConvertToGecko(). r=dlrobertson

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe20f47f85d9
Handle touchpad double-taps correctly in APZCTreeManager::ConvertToGecko(). r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/52ba9b55ca7c
Factor out a helper shared by the touch event and tap event handling codepaths. r=dlrobertson

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fe20f47f85d9
https://hg.mozilla.org/mozilla-central/rev/52ba9b55ca7c