1779277 - Moving tab, which came from another device, into new window will break it

Status: RESOLVED WORKSFORME

(Core :: Session Restore, defect)

Description

[juraj.masiar]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

1. open any extension page (uBlock dashboard page for example)
2. open the console and execute:

// this code will move received tab into new window
browser.tabs.onCreated.addListener(async tab => {
  console.log('tab created', tab);
  // sent tabs has this flag on
  if (!tab.attention) return;
  await browser.windows.create({tabId: tab.id});
});

3. using another device, send tab to this device
4. after it's received (and moved to a new window), right click on the tab and select "Duplicate Tab"

Actual results:

Empty tab is opened!
But that's not all, the tab is now broken and it will disappear after restarting Firefox, even if you have your session saved / restored. It's like the tab is not really there.

Expected results:

The tab should be duplicated and it should be saved by session restore.

This is a regression.
I've build addon "Send Tab to Device Enhancer" which does this (moves received tab into own window) and now these tabs disappears when I restart Firefox :(

https://addons.mozilla.org/en-US/firefox/addon/send-tab-to-device-enhancer/

Comment 1

[vcarciu]

I was able to reproduce this issue, so I performed a bisection in order to find the regresion with following results:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=dca4ad1dba273dfe205fc1e9d65eaf7e81502d7d&tochange=ba973417adb8c738b0ab57328fd28133c77bcf5b

2022-07-14T15:39:03: DEBUG : Found commit message:
Bug 1739450 - Part 2: Collect session history when wireframes are collected. r=peterv,mconley

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Andreas is out for an extended period, can you look and see if the regression makes sense for this behavior?

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Juraj, I was wondering: if you drag the drag got opened through sync manually by dragging and dropping the tab in a new window, does that also trigger a similar kind of issue?

Comment 5

[juraj.masiar]

Could you rephrase that? :)
But to clarify,

• the tab is opened all the time
• it's only moved from current window into newly created window using browser.windows.create({tabId: tab.id})
• the tab looks OK, it can be reloaded, it can be dragged and dropped into another window
• the tab can't be duplicated
• if you close the tab (and you have one more tab opened in the same window), you can't reopen it with Ctrl + Shift + T

You can reproduce this super easily, just run the code above in your Firefox and send it some tab from your phone.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to juraj.masiar from comment #5)

Could you rephrase that? :)

sure thing, sorry for not having been clear.

I was wondering if the bug would be reproducible (without an extension) if a user does the same kind of operation but manually (by creating a new window and then drag and dropping the tab opened through sync into the new window), instead of being the extension moving the tab using the WebExtensions APIs.

I was wondering that mainly to confirm if the issue may be triggered due to something that the extension API is doing internally or if it is happening as a side-effect of the code handling the tab adoption (which is shared between both the WebExtensions APIs and the Firefox code handling the user being drag and dropping tabs between windows).

Comment 7

[juraj.masiar]

Oh, I see, very good question!
And the answer is YES, when I drag and drop the received tab outside the window, new window is created and the tab is broken.

So it's not related to extensions after all!

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to juraj.masiar from comment #7)

Oh, I see, very good question!
And the answer is YES, when I drag and drop the received tab outside the window, new window is created and the tab is broken.

So it's not related to extensions after all!

Thanks a lot for double-checking that, very much appreciated!!!

It is pretty common for extensions to be able to trigger corner cases (or races) that can be technically be triggered by a user without any extension involved, and so once we got a clear STR it is often useful to confirm if it can be also reproduced without an extension, because it helps to look in the right place for where the actual underlying issue is (and often where it would be more reasonable to fix it).

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

The reporter confirmed that the regression can be reproduced without an extension (by manually moving tab opened by sync into a new window as a user could do without any extension installed) and so moving to "Firefox :: Session Restore" for further investigation.

Comment 10

[klausness]

Possibly related to Bug 1793598 or Bug 1779277.

Comment 11

[Shane Caraveo (:mixedpuppy)]

removing old ni?

Comment 12

[Sarah Clements [:sclements] | PTO until Sept 8th]

Andreas, can you look into this please? It looks like it might have been regressed by bug 1739450.

Comment 13

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1739450

Comment 14

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1739450

Comment 15

[Andreas Farre [:farre]]

(In reply to Sarah Clements [:sclements] from comment #12)

Andreas, can you look into this please? It looks like it might have been regressed by bug 1739450.

Yeah, this is pretty much saying that it was regressed by Fission, so it's difficult to say what and how happened in bug 1739450 that caused this. This could very much be a missing flush that needs to happen, I really don't know.

I think I'd like to send this back to triage, because I don't know how to fix this.

Comment 16

[Andreas Farre [:farre]]

Sarah, it seems like I'm not able to reproduce this. Not sure if I ever was. Are you ok with me closing it as won't fix?

Comment 17

[juraj.masiar]

I can confirm I'm unable to reproduce it anymore. Moving received tab into new window doesn't break it anymore.

Comment 18

[Sarah Clements [:sclements] | PTO until Sept 8th]

(In reply to Andreas Farre [:farre] from comment #16)

Sarah, it seems like I'm not able to reproduce this. Not sure if I ever was. Are you ok with me closing it as won't fix?

Yup, thanks for looking into it.