Closed Bug 1779549 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34844 - Revert "Add the beginning of hover-trigger for pop-ups"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34844 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34844
Details from upstream follow.

Theodore Olsauskas-Warren <sauski@google.com> wrote:

Revert "Add the beginning of hover-trigger for pop-ups"

This reverts commit cdbdb4520d6be65fdb04fc85aea5d12953f1a1da.

Reason for revert: Suspected cause of 1344436

Original change's description:

Add the beginning of hover-trigger for pop-ups

This CL adds the 'hoverpopup' attribute, to go along with the other
invoking attributes (togglepopup, showpopup, hidepopup). This attribute,
when places on any element, triggers a pop-up when hovered. With this
CL, it is always triggered after a fixed 100ms delay, but that will be
made configurable via CSS in subsequent CLs. There is also no "hide"
trigger when any element is de-hovered - again that will be added
later.

See this spec discussion:
https://github.com/openui/open-ui/issues/526#issuecomment-1161917067

Bug: 1307772
Change-Id: I7af88dad9efa015f833843ea76bed41b4aa42c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3759184
Reviewed-by: David Baron \<dbaron@chromium.org>
Auto-Submit: Mason Freed \<masonf@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1024141}

Bug: 1307772, 1344436
Change-Id: I65a1e36ead974e887c37b6a90ff6504fdaa45d71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/3760676
WPT-Export-Revision: 2d3561c1be7a49b9c630d223c29049875e984de0

PR 34844 applied with additional changes from upstream: c7e39f17e85310d0a42b595645f8ea7c217ead2c
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d031940d9a4 [wpt PR 34844] - Revert "Add the beginning of hover-trigger for pop-ups", a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/3d031940d9a4

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.