Closed Bug 1779594 Opened 3 years ago Closed 3 years ago

A console error on carousell.sg with ETP - Strict enabled reveals a bug with the Branch SDK SmartBlock shim

Categories

(Core :: Privacy: Anti-Tracking, defect, P3)

Product:
Core
Component:
Privacy: Anti-Tracking
Version:
Firefox 100
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: twisniewski, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

The page isn't breaking, but visiting https://www.carousell.sg/search/ps3 reveals that we're not handling Branch's queue properly:

TypeError: can't access property "apply", window.branch[fn] is undefined
    push https://cdn.branch.io/branch-latest.min.js:78
    <anonymous> https://cdn.branch.io/branch-latest.min.js:83
bundle.min.js:2:43400

Basically we need to change this line:

  const push = (fn, args) => {

to this:

  const push = ([fn, ...args]) => {
Blocks: 1776673

This was fixed in the Firefox 104 webcompat update in bug 1776673.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.