1779625 - Assign appropriate roles to about:welcome step indicator to make it more accessible for screen readers

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

The accessibility team noted that Mac's VoiceOver reaches the about:welcome “progress indicator”, but the element is read as navigation. It also isn’t actionable (ie. you can’t “click” on it) and doesn’t contain any text content, so it gets read as an “empty” navigation element. It does communicates the screen order (such as “1 of 2”), but we likely want to revisit the role and the name/label for the element.

It was noted that generally it might make more sense to set up these kind of flows as either:

• Using role=tab, role=tablist, or role=tabpanel - more on these roles here.
• Using the "progressbar" role - more on this role here

This update will improve accessibility of both the about:welcome onboarding flow and Spotlight modals as they share the same code.

Comment 1

[Negin Sauermann]

Attachment: Bug 1779625 - Assign appropriate roles to about:welcome step indicator to make it more accessible for screen readers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8042638bf0a
Assign appropriate roles to about:welcome step indicator to make it more accessible for screen readers r=emcminn,mviar,flod

Comment 3

[Atila Butkovits]

Backed out for causing failure at browser_aboutwelcome_multistage_primary.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c22aed0332ae0a97dfec9230328a5ba0aec2c292

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a8042638bf0a7d51cfa458220c987f92054fb812&selectedTaskRun=PteFBbUmTDKFHihuqFyZhw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=385481154&repo=autoland&lineNumber=11141

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96d4d5ce81a6
Assign appropriate roles to about:welcome step indicator to make it more accessible for screen readers r=emcminn,mviar,flod

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/96d4d5ce81a6

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 105.0a1 (Build ID: 20220811190443) on Windows 10 x64, macOS 12.3.1, and Linux Mint 20.2 x64.
The progress bar is read by the NVDA as “Progres bar: Progress 0 of 6” and so on.
The “Progress: Step 0 of 5, level indicator” is read by the VoiceOver and Orca