1779638 - Investigate intermittent Glean UI test in Android Components

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Travis Long [:travis_]]

The intermittent identified in this issue: https://github.com/mozilla-mobile/android-components/issues/12359

Is now being ignored after this PR. We should investigate and fix the issue, or remove the test if it is no longer serving its purpose.

Comment 1

[Jan-Erik Rediger [:janerik]]

Yes, I was looking into this. I think I have an idea how to fix it.

Comment 2

[Jan-Erik Rediger [:janerik]]

Test disabled in https://github.com/mozilla-mobile/android-components/pull/12503

Intermittents:
https://github.com/mozilla-mobile/android-components/issues/12311
https://github.com/mozilla-mobile/android-components/issues/12359

Failure:

java.lang.AssertionError: Assertion failed at mozilla.telemetry.glean.GleanInternalAPI.testSetLocalEndpoint$glean_release(Glean.kt:469)

Afaik this is a race between the local test server trying to set the config and Glean being initialized.
See this piece of code: https://github.com/mozilla/glean/blob/main/glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt#L468-L469

My idea would be to provide a way that we can ensure to run code after initialization (or immediately if its initialized)

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/2116

Comment 4

[Jan-Erik Rediger [:janerik]]

badboy merged PR #2116: "Bug 1779638 - Kotlin: Add a hook to run tasks after init" in 2c37bd7.

Keeping it open until we get that tested in a-c.
Still can't reproduce the initial error, but at the very least this doesn't make things worse.

Comment 5

[Jan-Erik Rediger [:janerik]]

Followup PR went into Glean 51.1.0 which should hopefully be landing in A-C today (https://github.com/mozilla-mobile/android-components/pull/12631)

Comment 6

[Jan-Erik Rediger [:janerik]]

PR to hopefully address this: https://github.com/mozilla-mobile/android-components/pull/12690

Comment 7

[Jan-Erik Rediger [:janerik]]

This landed in https://github.com/mozilla-mobile/android-components/commit/f1afc5d1bc64a546825013e520e8df94ed83cb1f