1779654 - [PBM] Add SpecialMessageAction BLOCK_MESSAGE that allows to block message

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add Special Message Action that blocks a message by id. We can block multiple messages by using BLOCK_MESSAGE call multiple times inside MULTI_ACTION

Its first use case will be in about:privatebrowsing where we want to hide Pin promo on current and preloaded tab after user clicks primary CTA 'Pin to taskbar'

      case "BLOCK_MESSAGE":
        await this.blockMessageById([
           message_id
        ]);
        break;

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1779654- Add SpecialMessageAction BLOCK_MESSAGE that allows to block message

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85390af1f767
Add SpecialMessageAction BLOCK_MESSAGE that allows to block message r=jprickett

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/85390af1f767

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the steps from the Test Plan on the latest Firefox Nightly 105.0a1 (Build ID: 20220815214739) on Windows 10 x64.

• If the 'browser.promo.pin.enabled' pref is set to true, the Pin promo message is displayed on about:privatebrowsing.
• The Pin promo message is no longer displayed on about:privatebrowsing after clicking the “Pin to taskbar” button, and the “PB_NEWTAB_PIN_PROMO” message is blocked on the ASRouter devtool.

Comment 5

[Simona Rosu [:srosu], Ecosystem QA]

I’m also marking this as Verified on 104 since this enhancement was part of the work done on QA-1577, for which we sent a green sign-off.