Closed Bug 1779720 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34857 - Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34857 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34857
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box.

If a FIELDSET is an OOF container, we made its anonymous content box
an OOF container by setting position:relative. It's bad because OOF
objects in the LEGEND is painted behind the anonymous content box. So
this CL updates OOF container conditions for anonymous fieldset content
boxes, and avoids setting position:relative.

  • ng_fieldset_algorithm.cc:
    Handle NGBreakStatus::kDisableFragmentation.
    Without this change, floated-multicol-in-multicol-crash.html in WPT has
    a DCHECK failure.

Bug: 1341413
Change-Id: I650b3020df53eba5d05f930bc44675b80ff4e90b

Reviewed-on: https://chromium-review.googlesource.com/3764404
WPT-Export-Revision: a00e23502a8977e6a709ea2ff8b348c80b0903cc

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81a8f32a8150
[wpt PR 34857] - Fieldset NG: Fix paint order of OOF objects in a LEGEND and the corresponding anonymous content box., a=testonly

https://hg.mozilla.org/mozilla-central/rev/81a8f32a8150

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.