1779798 - don't use private browsing taskbar icon when in permanent private browsing mode

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[[e-mail] (:bhearsum)]

I noticed some inconsistency here today. In some cases we use the regular Firefox icon, while in others we use the Private one. After a brief discussion with Romain, we decided we should never use the Private Browsing icon when in permanent private browsing mode.

There's at least two cases to fix here, although there may be more:

• Opening a New Private Window with the keyboard shortcut
• Starting Firefox with -private-window

I also want to look at what happens when a Private Browsing shortcut is used (which has the private browsing AUMID set, and uses -private-window -- I fear we may get a flicker of the Private Browsing icon, and then switch back to the regular one.)

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1779798: don't use private browsing taskbar icon when in permanent private browsing mode. r?nalexander!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76e9a7200932
don't use private browsing taskbar icon when in permanent private browsing mode. r=nalexander

Comment 3

[progress2048]

After updated Firefox beta to version 104, a new icon will pop up on taskbar when I open a new private window. Is it possible to add an option to add an option to disable this icon without using about:config?

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/76e9a7200932

Comment 5

[[e-mail] (:bhearsum)]

(In reply to progress2048 from comment #3)

After updated Firefox beta to version 104, a new icon will pop up on taskbar when I open a new private window. Is it possible to add an option to add an option to disable this icon without using about:config?

It sounds like you're part of a study group for this (you can check in about:studies).

For now, it's possible to disable by opting out of the study and ensuring that browser.privacySegmentation.windowSeparation.enabled is set to false. We don't have any plans to add this to about:preferences, though.

Comment 6

[progress2048]

(In reply to [e-mail] (:bhearsum) from comment #5)

It sounds like you're part of a study group for this (you can check in about:studies).

For now, it's possible to disable by opting out of the study and ensuring that browser.privacySegmentation.windowSeparation.enabled is set to false. We don't have any plans to add this to about:preferences, though.

I have already set 'browser.privacySegmentation.windowSeparation.enabled' to 'false' but I think I will in this study group to stay in touch with this issue.