1779847 - Logpoints are only visible in the Browser Toolbox when "Show content messages" is enabled

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Make sure that the Browser Toolbox is enabled, and then launch it
2. Set a log point somewhere in some code that you know you can run easily. I use tabbrowser.js's "addTab" method, which is called when creating a new tab.
3. Switch to the Console and (optionally) clear it
4. Add a new tab in your Firefox window

ER:

The log point should be sent to the console.

AR:

No log point is sent to the console.

I did some mozregression, and here's the range:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85700a1a4bcd3449b2b5c05795efa901ffa60a1b&tochange=7e98afbea170f7404dc63552d32ff208204d5414

nchevobbe, any idea which of these two bugs might have introduced this?

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the report Mike
We got similar report from tgiles this last month, and in this case, checking "Show content messages" in the console setting menu was showing the logpoints.
With the STR from Comment 0, I can see the logpoints with the option enabled.
This was regressed by Bug 1760590, but it only look like it revealed the underlying issue, which is that we probably don't set the chromeContext property to the appropriate value when firing logpoints (probably in https://searchfox.org/mozilla-central/rev/3cb31675aeffd10f1f6ae7c40e24b254da7798e5/devtools/server/actors/utils/logEvent.js#72-81 , called from https://searchfox.org/mozilla-central/rev/3cb31675aeffd10f1f6ae7c40e24b254da7798e5/devtools/server/actors/breakpoint.js#196-201).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1760590

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1779847 - [devtools] Add chromeContext property to logPoint messages. r=bomsy.

We only set it to true if the target the breakpoint
was hit in is a parent process target, which should
be enough.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d6c5856e64c
[devtools] Add chromeContext property to logPoint messages. r=bomsy.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d6c5856e64c