1779894 - Autofill does not work at twilio.com/login

Status: ASSIGNED

(Toolkit :: Password Manager: Site Compatibility, defect, P3)

Description

[Sam Johnson]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:104.0) Gecko/20100101 Firefox/104.0

Steps to reproduce:

1. Save login information for https://www.twilio.com in the Firefox password manager.
2. Visit https://www.twilio.com/login

Actual results:

When clicking in the Email field, my saved login information is not shown. I must manually type my email address every time. (Note, the password field does work, this bug is regarding the email field specifically)

Expected results:

Clicking the Email field should show my saved logins, like Chrome does for the same page.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Password Manager: Site Compatibility' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Issam Mani [:issammani]]

Hey,

Thanks for filing this.
I was able to reproduce the bug and after further investigation, it seems that for username-only login forms, we don't check for emails. This in turn causes our heuristic to ignore the email field.

In this method we are checking if a form is a username form only ( I am assuming here that a username could also mean an email ). Since we don't check whether the input field looks like an email field, this method returns false. This could be easily fixed by adding another check using isInferredEmailField.

Comment 3

[Issam Mani [:issammani]]

Attachment: Bug 1779894 - Detect email-like fields in username-only forms r=sgalich!

Comment 4

[Dimi Lee [:dimi]]

(In reply to Issam Mani [:issammani] from comment #2)

I was able to reproduce the bug and after further investigation, it seems that for username-only login forms, we don't check for emails. This in turn causes our heuristic to ignore the email field.

In this method we are checking if a form is a username form only ( I am assuming here that a username could also mean an email ). Since we don't check whether the input field looks like an email field, this method returns false. This could be easily fixed by adding another check using isInferredEmailField.

copy my comment in phabricator to explain why:

The reason I didn't add "email" when I implemented this feature is intentional. This is because there are many different scenarios when a site asks users to fill their email. And in many cases, the email field is not used as a username. For example, an email field to subscribe a newsletter.
When an email filed appear with a password field together in a form, we can guess that this email field is very likely a "username" field. But if there is no password field in the form, we'll need more hints to know whether the "email" field is used as username.