1779927 - Reuse existing `ChromeUtils.defineESModuleGetters` call in `./mach esmify`

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

When applying ./mach esmify --imports on single file multiple times for different set of modules, multiple ChromeUtils.defineESModuleGetters can be generated from XPCOMUtils.defineLazyModuleGetters.
Also there can be multiple ChromeUtils.defineModuleGetter calls.

it would be nice to find existing ChromeUtils.defineESModuleGetters call on the same object in the same level, and extending it instead of adding new ChromeUtils.defineESModuleGetters for each time.

Comment 1

[Tooru Fujisawa [:arai]]

example case that can use existing call: https://hg.mozilla.org/try/diff/7b2560b94ab3aa8a7088e6397d36974a6446a920/browser/actors/ContentSearchParent.jsm

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1779927 - Reuse existing ChromeUtils.defineESModuleGetters when converting lazy getters. r?Standard8!

When converting lazy getter calls, if the previous/next statement is
ChromeUtils.defineESModuleGetters, add properties into it, instead of
converting the lazy getter call into ChromeUtils.defineESModuleGetters
or creating new ChromeUtils.defineESModuleGetters call.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5447d4bcf563
Reuse existing ChromeUtils.defineESModuleGetters when converting lazy getters. r=Standard8

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5447d4bcf563