1779967 - Rewrite test_form_submission* tests with async function

Status: RESOLVED WONTFIX

(Toolkit :: Form Manager, task, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/search?q=test%2Ftest_form_submission&path=&case=false&regexp=false

those test use function callback heavily and that causes unexpected execution order that causes bug 1481802 and bug 1685473.

The test needs to be rewritten with async function that explicitly waits for each operation, with single control flow.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1779967 - Part 1: Rewrite test_form_submission* tests. r?MattN!

Use single async function that uses promise for waiting asynchronous things,
and explicitly wait for all of them.

Also fix test_form_submission_cap.html and test_form_submission_cap2.html
to properly use checkForSave and explicitly wait for the result.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1779967 - Part 2: Enable test_form_submission.html on all configuration. r?MattN!

Depends on D151997

Comment 3

[Tooru Fujisawa [:arai]]

try runs are green
https://treeherder.mozilla.org/jobs?repo=try&revision=4fed0056b35175ae692d9bdd0d2cf020f5baa345&group_state=expanded
https://treeherder.mozilla.org/jobs?repo=try&revision=9f503cf890c085ae8465e3d6ee56ef964dde7bd5&group_state=expanded

Comment 4

[Sergey Galich [:serg]]

FYI Bug 1642570 changes some of these tests. I'd recommend to wait for it to be fixed before proceeding with this one.