1780014 - Add Telemetry for First-try TLS and conservative mode handshakes

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Dennis Jackson]

We currently collect aggregate TLS Handshake telemetry for ECH and ECH GREASE modes, but there are two other circumstances we are interested in. Firstly, the success rate of initial connections, prior to any fallback attempts. Secondly, when we connect to vital resources (e.g. browser updates) we use 'conservative' mode and due to the importance of these resources we are especially interested in any intolerances.

Comment 2

[Dennis Jackson]

Attachment: Bug 1780014: Add specific telemetry for conservative and first-try handshakes. r=keeler.

This patch adds two new telemetry histograms which collect specific types
of TLS handshake seperately from existing handshakes. Existing tests
are also extended to ensure that the TLS handshake telemetry is collected
correctly.

Comment 3

[Dennis Jackson]

Attachment: data-review-conservative.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9285839 [details]
data-review-conservative.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Dennis Jackson is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/594a2a52a8c4
Add specific telemetry for conservative and first-try handshakes. r=keeler.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0d3f68420e0
Fix lint failure r=fix

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/594a2a52a8c4
https://hg.mozilla.org/mozilla-central/rev/e0d3f68420e0