No *.ini file in services/sync/tests/tps
Categories
(Firefox :: Sync, task)
Tracking
()
People
(Reporter: t.yavor, Unassigned)
Details
While I implemented a linter that checks files with a "test" in their path I found
services/sync/tests/tps which seems not to contain any *.ini file.
https://searchfox.org/mozilla-central/source/services/sync/tests/tps
Also a ./mach test services/sync/tests/tps is not executing any test, didn't find any *.ini that includes the files, so I was wondering if that is dead code?
|
||
Comment 1•2 years ago
•
|
||
:lyavor This isn't dead code. These tests use to be automated but are no longer run because they tend to be flaky. At present the sync team periodically runs these tests manually. So they're not triggered but they're also not dead.
|
Reporter | |
Comment 3•2 years ago
|
||
Thanks for information.
Do you plan to change the status quo of the tests? And if so, do you have a bug referring to that plan? (then I could link to the bug in the linter config to keep track of it)
For sure, we can close that one.
|
||
Comment 4•2 years ago
|
||
We don't really have concrete plans to move these to CI - most of the flakiness was due to the fact the tests run on production, so occasional 500 errors etc would cause false negatives in the tests - and we don't have the resources nor motivation to push it forward. The iOS mobile team also uses it, but like us, they do it all manually. More docs on TPS are at https://searchfox.org/mozilla-central/source/testing/tps/README, so maybe a link to that makes sense?
Happy to keep chatting about this, but for now I'll close it.
|
|
Reporter | |
Comment 5•2 years ago
|
||
Thank you very much!
That is good to know.
Description
•