1780084 - `mozilla::webgpu::Buffer::MapAsync` doesn't check `mValid`

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P3)

Description

[Jim Blandy :jimb]

mozilla::webgpu::Buffer::MapAsync will call SetMapped even if mValid is false, which seems wrong.

The WebGPU spec currently says that buffer validation should happen on the content timeline, but apparently that's supposed to change. But even if error reporting should happen on the Device timeline in the usual way, we should not be doing anything to the internal state of our Buffer object.

Comment 1

[Nicolas Silva [:nical]]

Moving to webgpu-v1 milestone since this is more about spec decisions than a bug I think. The pending buffer patches should handle things properly whether or not mValid is false.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jimb, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Nicolas Silva [:nical]]

Attachment: Bug 1780084 - Sanity-check for mValid before mapping the buffer. r=#webgpu-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06cdccafe8f
Sanity-check for mValid before mapping the buffer. r=webgpu-reviewers,ErichDonGubler

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c06cdccafe8f