Closed Bug 1780152 Opened 3 years ago Closed 3 years ago

Update document about offset and breakpoint to reflect breakpoint-not-allowed case

Categories

(Core :: JavaScript Engine, task, P1)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1780152 - Update Debugger.Script document to cover breakpoint-not-allowed instructions. r?mgaudet!
48 bytes, text/x-phabricator-request
Details | Review

Bug 1776376 adds a case that setBreakpoint throws even if the offset is valid.
This can affect the expectation around when setBreakpoint can be called, for what kind of offset returned from what API.

Bug 1780134 case hits this, by calling setBreakpoint on getEffectfulOffsets.

We should update the document to mention the "not-allowed" case, and clarify the relation between offset and breakpoint.

Depends on: 1780158
Blocks: js-debugger
Severity: -- → N/A
Priority: -- → P1
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/e6ac351e4f0e Update Debugger.Script document to cover breakpoint-not-allowed instructions. r=mgaudet

https://hg.mozilla.org/mozilla-central/rev/e6ac351e4f0e

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: