1780154 - Consider scroll-snap-type:proximity in ScrollSnapUtils::GetSnapPointForResnap

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

This is the cause of bug 1779909 comment 12.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

The root cause here is that in this else branch. We unconditionally set snap flag to true in the branch so that we consider the snap target element is a valid last snap target even if we won't snap to the position, thus when a re-snapping happens we try to snap the original snap position.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1780154 - Skip returning the snap target if the scroll-snap-type on the axis is `none`. r?botond

If we return the snap target in such cases, even though the target position is
unchanged from the original scroll destination, the target will be handled as a
valid last-snapped target element, thus we will try to re-snap to the element's
scroll-snap-align position rather than keeping the scroll position as it is.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68caee424b21
Skip returning the snap target if the scroll-snap-type on the axis is `none`. r=botond

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35215 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/68caee424b21

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot