17802 - oji fails to compile with workshop c++ 5.0 compiler

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect, P3)

Description

[Akhil Arora]

oji fails to compile with workshop c++ 5.0 compiler on solaris 7

CC -library=iostream -o lcglue.o -c   -DMOZILLA_CLIENT -DNECKO=1
-DBROKEN_QSORT=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\"
-DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_IPC_H=1 -DHAVE_SYS_SHM_H=1
-DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBRESOLV=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1 -DHAVE_LIBELF=1
-DHAVE_LIBINTL=1 -DHAVE_LIBPOSIX4=1 -DHAVE_LIBW=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1 -DHAVE_VALLOC=1
-DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_USING=1 -DHAVE_CPP_NEW_CASTS=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_MAIL_NEWS=1 -DClientWallet=1
-DCookieManagement=1 -DSingleSignon=1 -DNDEBUG=1 -DTRIMMED=1
-DMOZ_USER_DIR=\".mozilla\" -DMOZ_DISABLE_DTD_DEBUG=1 -DMOZ_DLL_SUFFIX=\".so\"
-DXP_UNIX=1 -DUNIX_EMBED=1 -DX_PLUGINS=1 -DUNIX_LDAP=1 -DUNIX_ASYNC_DNS=1
-DJS_THREADSAFE=1 -DLAYERS=1  -mt -fast  -KPIC  -DOSTYPE=\"SunOS5\" -DOJI
-I../../../dist/include -I../../../dist/include -I../../../dist/include
-I../../../include  -I../../../dist/public/jpeg -I../../../dist/public/png
-I../../../dist/public/zlib  -I../../../dist/include/private
-I/usr/openwin/include  lcglue.cpp
"lcglue.cpp", line 89: Error: Cannot use void(*)(void*) to initialize
ThreadLocalStorage<JVMContext*>.
"lcglue.cpp", line 89: Error: Cannot use void(*)(void*) to initialize
ThreadLocalStorage<JVMContext*>.
2 Error(s) detected.
gmake[2]: *** [lcglue.o] Error 2
gmake[2]: Leaving directory `/opt/ws/mozilla/modules/oji/src'
gmake[1]: *** [libs] Error 2
gmake[1]: Leaving directory `/opt/ws/mozilla/modules/oji'
gmake: *** [libs] Error 2

Comment 1

[Akhil Arora]

the following fixes the problem -

Index: lcglue.cpp
===================================================================
RCS file: /cvsroot/mozilla/modules/oji/src/lcglue.cpp,v
retrieving revision 1.15
diff -r1.15 lcglue.cpp
89c89
<       static ThreadLocalStorage<JVMContext*> localContext(&detach_JVMContext);
---
>       static ThreadLocalStorage<JVMContext*>
localContext((PRThreadPrivateDTOR)&detach_JVMContext);

Comment 2

[Paul Wyskoczka]

Developer bug. Marking verified 1999122008.

Comment 3

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/d24774c3a22b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17802: Match the design for three-dot menu navigation (https://github.com/mozilla-mobile/fenix/pull/17875)