1780233 - Bundled fonts cause startup crash on mac

Status: NEW

(Core :: Graphics: Text, defect, P3)

Description

[Nicolas Silva [:nical]]

I have been unable to run any local build for a few days on mac m1 max

nical(~/dev/mozilla/unified): ./mach run
 0:00.32 /Users/nical/dev/mozilla/objdir/dbg/dist/NightlyDebug.app/Contents/MacOS/firefox -no-remote -foreground -profile /Users/nical/dev/mozilla/objdir/dbg/tmp/profile-default
[2022-07-19T15:09:14Z WARN  rkv::backend::impl_safe::environment] `load_ratio()` is irrelevant for this storage backend.
[Socket 3057, Main Thread] WARNING: 'NS_FAILED(rv)', file /Users/nical/dev/mozilla/unified/netwerk/protocol/http/nsHttpHandler.cpp:339
2022-07-19 17:09:14.657 plugin-container[3057:52257] nil host used in call to allowsSpecificHTTPSCertificateForHost
2022-07-19 17:09:14.657 plugin-container[3057:52257] nil host used in call to allowsAnyHTTPSCertificateForHost:
Assertion failure: NS_IsMainThread() (Do not call dirsvc::get on non-main threads!), at /Users/nical/dev/mozilla/unified/xpcom/io/nsDirectoryService.cpp:191
#01: nsDirectoryService::Get(char const*, nsID const&, void**)[/Users/nical/dev/mozilla/objdir/dbg/toolkit/library/build/XUL +0x2562d4]
#02: NS_GetSpecialDirectory(char const*, nsIFile**)[/Users/nical/dev/mozilla/objdir/dbg/toolkit/library/build/XUL +0x42d8c]
#03: gfxPlatformMac::WaitForFontRegistration()[/Users/nical/dev/mozilla/objdir/dbg/toolkit/library/build/XUL +0x1218d80]
#04: gfxMacPlatformFontList::InitSharedFontListForPlatform()[/Users/nical/dev/mozilla/objdir/dbg/toolkit/library/build/XUL +0x12a42b4]
#05: gfxPlatformFontList::InitFontList()[/Users/nical/dev/mozilla/objdir/dbg/toolkit/library/build/XUL +0x1264bd4]
#06: InitFontListCallback(void*)[/Users/nical/dev/mozilla/objdir/dbg/toolkit/library/build/XUL +0x1264814]
#07: _pt_root[/Users/nical/dev/mozilla/objdir/dbg/dist/NightlyDebug.app/Contents/MacOS/libnss3.dylib +0x17c490]
#08: _pthread_start[/usr/lib/system/libsystem_pthread.dylib +0x726c]
[Socket 3057, IPC I/O Child] WARNING: [28805552AF21E981.D7336C4F4A9AE612]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /Users/nical/dev/mozilla/unified/ipc/glue/NodeController.cpp:352
[Socket 3057, IPC I/O Child] WARNING: [28805552AF21E981.D7336C4F4A9AE612]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /Users/nical/dev/mozilla/unified/ipc/glue/NodeController.cpp:352
[Socket 3057, IPC I/O Child] WARNING: [28805552AF21E981.D7336C4F4A9AE612]: Ignoring message 'EVENT_MESSAGE' to peer 1.1 due to a missing broker: file /Users/nical/dev/mozilla/unified/ipc/glue/NodeController.cpp:352
[Socket 3057, Main Thread] WARNING: Shutting down Socket process early due to a crash!: file /Users/nical/dev/mozilla/unified/netwerk/ipc/SocketProcessChild.cpp:177

Comment 1

[Nicolas Silva [:nical]]

So the problem comes from having

ac_add_options --enable-bundled-fonts

in my mozconfig.

Comment 2

[Jonathan Kew [:jfkthame]]

Ugh... yeah, we need to move this out of the InitFontList thread and ensure we do it from the main thread.

(There's another macOS bundled fonts issue in bug 1774413, too, so we should try to clean all this up properly while we're touching this code.)