1780264 - Remove rarely used style structs cached in ReflowInput

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

We cache various style structs in ReflowInput. I believe they were invented in ancient time because getting them in old style system is expensive, but with our current style system (servo), they are a lot cheaper. We already have a lot of usages throughout the layout module just calling frame->StyleText() for example.

ReflowInput is initialized every time we reflow a frame, so we can at least remove some structs that are seldom used to save resources.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1780264 Part 1 - Remove ReflowInput::mStyleVisibility. r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1780264 Part 2 - Remove ReflowInput::mStylePadding. r?#layout

Depends on D152202

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1780264 Part 3 - Remove ReflowInput::mStyleText. r?#layout

Depends on D152203

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e628bf79a4dd
Part 1 - Remove ReflowInput::mStyleVisibility. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/63821d2687e3
Part 2 - Remove ReflowInput::mStylePadding. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1aa4139cf6bf
Part 3 - Remove ReflowInput::mStyleText. r=emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e628bf79a4dd
https://hg.mozilla.org/mozilla-central/rev/63821d2687e3
https://hg.mozilla.org/mozilla-central/rev/1aa4139cf6bf