1780328 - Chat core start-up takes a very long time, blocks Thunderbird start-up

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

By commenting out the auth prompt in chatHandler.jsm, the time taken from Thunderbird start-up to first paint drops from 4.1s to 1.5s, on my test profile.

This code looks like it starts everything in chat, which is fine, but we need to move it so it's not blocking the UI.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1780328 - Initialising the Chat core after the first window loads. r=freaktechnik

The current method of running this code inside a password prompt causes the UI thread to wait until Chat is initialised, causing a major delay in painting the program on the screen.
And it appears to no longer be required. At least one other thing causes a primary password prompt at start-up, and even if that is cancelled calling the login service functions bring up the prompt.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d2810b742e64
Initialising the Chat core after the first window loads. r=freaktechnik

Comment 3

[Geoff Lankow (:darktrojan)]

We should take this one to ESR, it's such a big improvement. But not before it gets a good workout on beta.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9286194 [details]
Bug 1780328 - Initialising the Chat core after the first window loads. r=freaktechnik

[Triage Comment]
Approved for esr102

It's been on 104 for a month, so should be solid.

Comment 5

[Rob Lemley [:rjl]]

Attachment: 1780328-esr102.patch

Modified for comm-esr102.

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9290512 [details] [diff] [review]
1780328-esr102.patch

LGTM.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.2.0:
https://hg.mozilla.org/releases/comm-esr102/rev/5aeb819064ac