1780383 - Add profiler sub-category for Wasm code

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Jan de Mooij [:jandem]]

While looking at a Wasm-related profiler issue today, I noticed that Wasm frames don't have their own category so time in Wasm code is often labeled as "JS Interpreter" or "JS Baseline".

Here are profiles without and with a new Wasm sub-category:

before: https://share.firefox.dev/3B4wTol
after: https://share.firefox.dev/3B8Ykh3

(Profile for a debug build, but it does demonstrate the new Wasm category.)

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1780383 - Add profiler sub-category for Wasm frames. r?gerald!,rhunt!

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #0)

after: https://share.firefox.dev/3B8Ykh3

Note that Wasm frames show up as "JavaScript: Wasm", which is okay I think considering Wasm is part of the JS Engine. It also doesn't distinguish Wasm Baseline/Ion/stubs code yet, we'd have to change the JS profiling interface a bit to pass that information, but I think it's an improvement anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0df5222aec96
Add profiler sub-category for Wasm frames. r=gerald,rhunt

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0df5222aec96