1780475 - Obey contain-intrinsic-size in ContainSizeAxes::ContainIntrinsicSize and ContainSizeAxes::ContainSize

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Oriol Brufau [:Oriol]]

ContainSizeAxes::ContainIntrinsicSize and ContainSizeAxes::ContainSize just use 0 for the contained axes.

They should use the values coming from contain-intrinsic-size.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1780475 - Store contain-intrinsic-size in nsStyleDisplay. r?emilio

This way ContainSizeAxes will be able to use it.
There should be no observable change in behavior.

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1780475 - Obey contain-intrinsic-size in ContainSizeAxes. r?emilio

ContainSizeAxes::ContainSize and ContainSizeAxes::ContainIntrinsicSize
were just using 0 for the axes with size containment, now they will take
contain-intrinsic-width and contain-intrinsic-height into account.

There are various places that aren't currently using these functions, so
the effect of this patch is rather minimal, but some cases of the new
test are now passing.

Depends on D152354

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2120ff6ddc22
Obey contain-intrinsic-size in ContainSizeAxes. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34934 for changes under testing/web-platform/tests

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2120ff6ddc22

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot