1780540 - MOZ_LOG="fontlist:5" perma crashes all tabs

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[:gerard-majax]

STR:

• build m-c
• MOZ_LOG=fontlist:5 ./mach run

Expected
Tab open

Actual
Tab crash reported

Comment 1

[Emilio Cobos Álvarez (:emilio)]

https://searchfox.org/mozilla-central/rev/a352cc827575823676717d53766c39710b54201a/gfx/thebes/gfxFcPlatformFontList.cpp#462-473:

charmap is nulled out then we dereference it.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1780540 - Don't forget charmap after setting in a font entry. r=jfkthame

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1763414

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f75ba849f09
Don't forget charmap after setting in a font entry. r=jfkthame

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on gfxFcPlatformFontList.cpp

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e80c5ded53d6
Don't forget charmap after setting in a font entry. r=jfkthame

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e80c5ded53d6

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox103 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Probably not, logging-only change in practice.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

We should probably fix this on ESR, though. Please nominate if you agree.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9286408 [details]
Bug 1780540 - Don't forget charmap after setting in a font entry. r=jfkthame

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Font logging insta-crashes the tabs.
• User impact if declined: none
• Fix Landed on Version: 104
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Really simple fix.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9286408 [details]
Bug 1780540 - Don't forget charmap after setting in a font entry. r=jfkthame

Approved for 102.2esr.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/87ebdf7370e8