1780581 - consider helper function to identify moz-extension scheme urls

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P5)

Description

[Shane Caraveo (:mixedpuppy)]

To replace url.startsWith("moz-extension://"), perhaps ExtensionUtils.isExtensionUrl(url)

Comment 1

[Rob Wu [:robwu]]

This was a follow-up from https://phabricator.services.mozilla.com/D151766#inline-838451 from bug 1711168.

e.g. at https://searchfox.org/mozilla-central/rev/dcb0cfb66e4ed3b9c7fbef1e80572426ff5f3c3a/browser/components/extensions/parent/ext-tabs.js#749,763

Comment 2

[kernp25]

What`s with favIconUrl.startsWith("blob:") and other protocols?

Comment 3

[Rob Wu [:robwu]]

(In reply to kernp25 from comment #2)

What`s with favIconUrl.startsWith("blob:") and other protocols?

blob:-URLs may be generated internally for built-in search engines. In the source code you linked, blob:-URLs are converted to data:-URLs because extensions would otherwise encounter a URL that they cannot load. The context for that is in a regression that you reported before (bug 1918386) that we fixed.

Comment 4

[kernp25]

I mean, should the helper function also work for blob: and other protocols?

Or just moz-extension:?

Maybe isUrlScheme(url)?

Comment 5

[kernp25]

Maybe isUrlScheme(url)?

Should be isUrlScheme(url, "blob")

Comment 6

[Rob Wu [:robwu]]

(In reply to kernp25 from comment #4)

I mean, should the helper function also work for blob: and other protocols?

Or just moz-extension:?

Just moz-extension:.

Note that the implementation that calls .startWith("moz-extension://") assumes that the URL is already normalized. In situations where a nsIURI or (standard) URL is available, .schemeIs("moz-extension") and .protocol === "moz-extension:" can already be used instead, with clarity.

A search query showing some current uses of "moz-extension: in JS is at https://searchfox.org/mozilla-central/search?q=%22moz-extension%3A&path=.*js&case=false&regexp=false

Comment 7

[Christina]

Attachment: Bug 1780581 - Add isExtensionUrl Helper Function. r=zombie

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3183b8c2fe9
https://hg.mozilla.org/integration/autoland/rev/10b16a392a14
Add isExtensionUrl Helper Function. r=zombie,geckoview-reviewers,settings-reviewers,devtools-reviewers,omc-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,pdahiya,bomsy,mconley

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b200209e9111
https://hg.mozilla.org/integration/autoland/rev/bc47b67617b4
Revert "Bug 1780581 - Add isExtensionUrl Helper Function. r=zombie,geckoview-reviewers,settings-reviewers,devtools-reviewers,omc-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,pdahiya,bomsy,mconley" for causing DT failures @browser_dbg-javascript-tracer-worker.js

Comment 10

[pstanciu]

Backed out for causing DT failures @browser_dbg-javascript-tracer-worker.js

• https://hg.mozilla.org/integration/autoland/rev/bc47b67617b4662ee34383566d3be459cf0c6987
• Push with failures
• Failure Log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a84124f52f32
https://hg.mozilla.org/integration/autoland/rev/42aab21bf427
Add isExtensionUrl Helper Function. r=zombie,geckoview-reviewers,settings-reviewers,devtools-reviewers,omc-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,pdahiya,bomsy,mconley

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/268b6a1b89e7
https://hg.mozilla.org/integration/autoland/rev/10a03896c9ac
Revert "Bug 1780581 - Add isExtensionUrl Helper Function. r=zombie,geckoview-reviewers,settings-reviewers,devtools-reviewers,omc-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,pdahiya,bomsy,mconley" for causing mochitests-plain failures in test_ext_idle.html.

Comment 13

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests-plain failures in test_ext_idle.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/mochitest/test_ext_idle.html | Idle status is active - Expected: active, Actual: idle

Comment 14

[Rob Wu [:robwu]]

The above backout was unrelated to the patch here; I fixed the intermittent failures of test_ext_idle.html in bug 1947300.

The patch needs to be re-uploaded (to work around https://bugzilla.mozilla.org/show_bug.cgi?id=1963406#c6 ), but other than that it should be ready to land.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d64188064b9b
https://hg.mozilla.org/integration/autoland/rev/bb3bcfc6bd5e
Add isExtensionUrl Helper Function. r=zombie,geckoview-reviewers,settings-reviewers,devtools-reviewers,omc-reviewers,home-newtab-reviewers,urlbar-reviewers,Standard8,pdahiya,bomsy,mconley

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bb3bcfc6bd5e