Closed Bug 1780666 Opened 11 months ago Closed 10 months ago

Clean up Windows toast notification implementation files.

Categories

(Toolkit :: Notifications and Alerts, task, P3)

Product:
Toolkit
Component:
Notifications and Alerts
Platform:
Desktop
Windows
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: nrishel, Assigned: nrishel)

References

Details

(Whiteboard: [fidedi-ope])

Attachments

(2 files)

Bug 1780666 - Part 1: Manage Windows toast notifcation HSTRING handles lifetime with HString and HStringReference wrappers. r=nalexander
48 bytes, text/x-phabricator-request
Details | Review
Bug 1780666 - Part 2: Condense litany of Windows toast notification error cases with NS_ENSURE_* macros. r=nalexander.
48 bytes, text/x-phabricator-request
Details | Review

The implementation for Windows toast notification error handling is particularly noisy, notably having strings of if..return. These can be condensed with the NS_ENSURE_* macros.

Additionally HSTRING from the Windows API is used, and it appears that resources are not being released. These would be better consolidated on wrl's HString and HStringReference RAII wrapper classes.

Flags: needinfo?(tspurway)
Whiteboard: [fidedi-ope]
Pushed by nrishel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99eafc30104b
Part 1: Manage Windows toast notifcation HSTRING handles lifetime with HString and HStringReference wrappers. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/79e260057dbd
Part 2: Condense litany of Windows toast notification error cases with NS_ENSURE_* macros. r=nalexander,mhowell.

https://hg.mozilla.org/mozilla-central/rev/99eafc30104b
https://hg.mozilla.org/mozilla-central/rev/79e260057dbd

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Flags: needinfo?(tspurway)
You need to log in before you can comment on or make changes to this bug.