1780666 - Clean up Windows toast notification implementation files.

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, task, P3)

Description

[Nick Rishel [:nrishel]]

The implementation for Windows toast notification error handling is particularly noisy, notably having strings of if..return. These can be condensed with the NS_ENSURE_* macros.

Additionally HSTRING from the Windows API is used, and it appears that resources are not being released. These would be better consolidated on wrl's HString and HStringReference RAII wrapper classes.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1780666 - Part 1: Manage Windows toast notifcation HSTRING handles lifetime with HString and HStringReference wrappers. r=nalexander

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1780666 - Part 2: Condense litany of Windows toast notification error cases with NS_ENSURE_* macros. r=nalexander.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99eafc30104b
Part 1: Manage Windows toast notifcation HSTRING handles lifetime with HString and HStringReference wrappers. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/79e260057dbd
Part 2: Condense litany of Windows toast notification error cases with NS_ENSURE_* macros. r=nalexander,mhowell.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/99eafc30104b
https://hg.mozilla.org/mozilla-central/rev/79e260057dbd