Closed
Bug 1780666
Opened 2 years ago
Closed 2 years ago
Clean up Windows toast notification implementation files.
Categories
(Toolkit Graveyard :: Notifications and Alerts, task, P3)
Tracking
(firefox105 fixed)
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: nrishel, Assigned: nrishel)
References
Details
(Whiteboard: [fidedi-ope])
Attachments
(2 files)
The implementation for Windows toast notification error handling is particularly noisy, notably having strings of if..return. These can be condensed with the NS_ENSURE_* macros.
Additionally HSTRING from the Windows API is used, and it appears that resources are not being released. These would be better consolidated on wrl's HString and HStringReference RAII wrapper classes.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Flags: needinfo?(tspurway)
|
||
Updated•2 years ago
|
Whiteboard: [fidedi-ope]
|
||
Updated•2 years ago
|
Pushed by nrishel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/99eafc30104b Part 1: Manage Windows toast notifcation HSTRING handles lifetime with HString and HStringReference wrappers. r=nalexander https://hg.mozilla.org/integration/autoland/rev/79e260057dbd Part 2: Condense litany of Windows toast notification error cases with NS_ENSURE_* macros. r=nalexander,mhowell.
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/99eafc30104b
https://hg.mozilla.org/mozilla-central/rev/79e260057dbd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
|
||
Updated•2 years ago
|
Flags: needinfo?(tspurway)
|
||
Updated•10 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•