1780752 - script callFunction and evaluate fail if the script throws an object which doesn't implement toString()

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Julian Descottes [:jdescottes]]

When a call to script.evaluate/callFunction encounters an exception, the logic to extract the text is really weak:

text:
  typeof exception === "object"
    ? exception.toString()
    : String(exception),

https://searchfox.org/mozilla-central/rev/15b656909e77d3048d4652b894f79a8c719b4b86/remote/webdriver-bidi/modules/windowglobal/script.jsm#91-95

First this will fail on null as it is an object but has no toString property. But it would also fail on a random object such as { toString: "not a method" } or any other variant.

For null, the test should be covered by extending our exception_details test cases to cover primitives. For random objects, it might be worth adding a mozilla-specific wdspec test. Or we can extract some of that logic to a dedicated helper and add xpcshell tests.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1780752 - [bidi] Handle exception objects which don't support toString

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2eab01956e47
[bidi] Handle exception objects which don't support toString r=webdriver-reviewers,jgraham

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34945 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2eab01956e47

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Post-adding to M4 given that this work is part of it and the project was only on-hold when the patch got landed.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The upstream PR got merged via https://github.com/web-platform-tests/wpt/pull/34945.