17809 - does not compile with Sun Workshop 5.0 C++ compiler

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Akhil Arora]

gmake[2]: Entering directory `/opt/ws/mozilla/modules/plugin/nglsrc'
CC -library=iostream -o nsPluginHostImpl.o -c   -DMOZILLA_CLIENT -DNECKO=1
-DBROKEN_QSORT=1 -DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\"
-DSTDC_HEADERS=1 -DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_IPC_H=1 -DHAVE_SYS_SHM_H=1
-DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBRESOLV=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1 -DHAVE_LIBELF=1
-DHAVE_LIBINTL=1 -DHAVE_LIBPOSIX4=1 -DHAVE_LIBW=1 -D_REENTRANT=1 -DHAVE_RANDOM=1
-DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1 -DHAVE_VALLOC=1
-DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_USING=1 -DHAVE_CPP_NEW_CASTS=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_MAIL_NEWS=1 -DClientWallet=1
-DCookieManagement=1 -DSingleSignon=1 -DNDEBUG=1 -DTRIMMED=1
-DMOZ_USER_DIR=\".mozilla\" -DMOZ_DISABLE_DTD_DEBUG=1 -DMOZ_DLL_SUFFIX=\".so\"
-DXP_UNIX=1 -DUNIX_EMBED=1 -DX_PLUGINS=1 -DUNIX_LDAP=1 -DUNIX_ASYNC_DNS=1
-DJS_THREADSAFE=1 -DLAYERS=1  -mt -fast  -KPIC  -DOSTYPE=\"SunOS5\" -DOJI
-D_IMPL_NS_PLUGIN  -I../../../dist/include -I../../../dist/include
-I../../../dist/include -I../../../include  -I../../../dist/public/jpeg
-I../../../dist/public/png -I../../../dist/public/zlib  -I/usr/openwin/include
nsPluginHostImpl.cpp
"nsPluginHostImpl.cpp", line 2038: Error: Cannot use const char* to initialize
char*.
"nsPluginHostImpl.cpp", line 2051: Error: Cannot assign const char* to char*.
"nsPluginHostImpl.cpp", line 2313: Warning (Anachronism): Cannot cast from void*
to unsigned(*)(nsISupports*,const nsID&,const char*,const char*,nsIFactory**).
2 Error(s) and 1 Warning(s) detected.
gmake[2]: *** [nsPluginHostImpl.o] Error 2
gmake[2]: Leaving directory `/opt/ws/mozilla/modules/plugin/nglsrc'
gmake[1]: *** [libs] Error 2
gmake[1]: Leaving directory `/opt/ws/mozilla/modules/plugin'
gmake: *** [libs] Error 2


However, the following simple change fixes it. Please code review and let me
know if it is OK to check in the fix.

Index: nsPluginHostImpl.cpp
===================================================================
RCS file: /cvsroot/mozilla/modules/plugin/nglsrc/nsPluginHostImpl.cpp,v
retrieving revision 1.81
diff -r1.81 nsPluginHostImpl.cpp
2038c2038
<   char *pComma = strchr(pExt, ',');
---
>   const char *pComma = strchr(pExt, ',');

Comment 1

[Akhil Arora]

Reminder: Trivial fix, permission to check in?

Comment 2

[av (gone)]

Looks fine to me

Comment 3

[Eli Goldberg]

Akhil, might you care to confirm that whether or not issue has been fixed, and
mark the bug as "Verified" or "Reopened" as appropriate? (I don't have the
ability to verify this issue on readily available hardware.)

Thank you!

Comment 4

[Akhil Arora]

Fixed. Works fine. Verified.