1780928 - Build bustages /builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.cpp:52:11: error: enumeration value 'CallRef' not handled in switch [-Werror,-Wswitch] when Gecko 104 merges to Beta on 2022-07-25

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=385200133&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fcOE2JsRSZS_k_Zu4szMtg/runs/0/artifacts/public/logs/live_backing.log

---

[Central-as-beta simulation](https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c24add1df98bd664490042a36e708612165ee7f1&searchStr=sm&selectedTaskRun=fcOE2JsRSZS_k_Zu4szMtg.0)
[How to run these simulations](https://wiki.mozilla.org/Sheriffing/How_To/Beta_simulations#TRUNK_AS_EARLY_BETA)
[Failure log](https://treeherder.mozilla.org/logviewer?job_id=385200133&repo=try&lineNumber=5933)

[task 2022-07-23T10:56:54.602Z] js/src/jit/Unified_cpp_js_src_jit3.o
[task 2022-07-23T10:56:54.602Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-spider/js/src/jit'
[task 2022-07-23T10:56:55.791Z] gmake[4]: Entering directory '/builds/worker/workspace/obj-spider/js/src/wasm'
[task 2022-07-23T10:56:55.791Z] /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu++17 -m32 -o Unified_cpp_js_src_wasm4.o -c -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DDEBUG=1 -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/js/src/wasm -I/builds/worker/workspace/obj-spider/js/src/wasm -I/builds/worker/workspace/obj-spider/js/src -I/builds/worker/checkouts/gecko/js/src -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -msse -msse2 -mfpmath=sse -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -O3 -fno-omit-frame-pointer -funwind-tables -Werror -Werror=format -fno-strict-aliasing -ffp-contract=off -MD -MP -MF .deps/Unified_cpp_js_src_wasm4.o.pp Unified_cpp_js_src_wasm4.cpp
[task 2022-07-23T10:56:55.791Z] In file included from Unified_cpp_js_src_wasm4.cpp:2:
[task 2022-07-23T10:56:55.792Z] /builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.cpp:52:11: error: enumeration value 'CallRef' not handled in switch [-Werror,-Wswitch]
[task 2022-07-23T10:56:55.792Z] switch (Op(op.b0)) {
[task 2022-07-23T10:56:55.792Z] ^~~~~~~~~
[task 2022-07-23T10:56:55.792Z] 1 error generated.
[task 2022-07-23T10:56:55.792Z] gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: Unified_cpp_js_src_wasm4.o] Error 1
[task 2022-07-23T10:56:55.792Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-spider/js/src/wasm'
[task 2022-07-23T10:56:55.792Z] gmake[4]: *** Waiting for unfinished jobs....
[task 2022-07-23T10:56:55.793Z] gmake[4]: Entering directory '/builds/worker/workspace/obj-spider/js/src/jit'
[task 2022-07-23T10:56:55.793Z] js/src/jit/Unified_cpp_js_src_jit4.o

Comment 1

[Cosmin Sabou [:CosminS]]

Central-as-beta simulation
How to run these simulations
Failure log

[task 2022-07-23T10:56:54.602Z] js/src/jit/Unified_cpp_js_src_jit3.o
[task 2022-07-23T10:56:54.602Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-spider/js/src/jit'
[task 2022-07-23T10:56:55.791Z] gmake[4]: Entering directory '/builds/worker/workspace/obj-spider/js/src/wasm'
[task 2022-07-23T10:56:55.791Z] /builds/worker/fetches/clang/bin/clang++ --sysroot /builds/worker/fetches/sysroot-i686-linux-gnu -std=gnu++17 -m32 -o Unified_cpp_js_src_wasm4.o -c -I/builds/worker/workspace/obj-spider/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fstack-clash-protection -DDEBUG=1 -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/checkouts/gecko/js/src/wasm -I/builds/worker/workspace/obj-spider/js/src/wasm -I/builds/worker/workspace/obj-spider/js/src -I/builds/worker/checkouts/gecko/js/src -I/builds/worker/workspace/obj-spider/dist/include -I/builds/worker/workspace/obj-spider/dist/include/nspr -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-spider/js/src/js-confdefs.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wdeprecated-this-capture -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wc++2a-compat -Wcomma -Wenum-compare-conditional -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=free-nonheap-object -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wthread-safety -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -msse -msse2 -mfpmath=sse -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -O3 -fno-omit-frame-pointer -funwind-tables -Werror -Werror=format -fno-strict-aliasing -ffp-contract=off -MD -MP -MF .deps/Unified_cpp_js_src_wasm4.o.pp Unified_cpp_js_src_wasm4.cpp
[task 2022-07-23T10:56:55.791Z] In file included from Unified_cpp_js_src_wasm4.cpp:2:
[task 2022-07-23T10:56:55.792Z] /builds/worker/checkouts/gecko/js/src/wasm/WasmOpIter.cpp:52:11: error: enumeration value 'CallRef' not handled in switch [-Werror,-Wswitch]
[task 2022-07-23T10:56:55.792Z] switch (Op(op.b0)) {
[task 2022-07-23T10:56:55.792Z] ^~~~~~~~~
[task 2022-07-23T10:56:55.792Z] 1 error generated.
[task 2022-07-23T10:56:55.792Z] gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:669: Unified_cpp_js_src_wasm4.o] Error 1
[task 2022-07-23T10:56:55.792Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-spider/js/src/wasm'
[task 2022-07-23T10:56:55.792Z] gmake[4]: *** Waiting for unfinished jobs....
[task 2022-07-23T10:56:55.793Z] gmake[4]: Entering directory '/builds/worker/workspace/obj-spider/js/src/jit'
[task 2022-07-23T10:56:55.793Z] js/src/jit/Unified_cpp_js_src_jit4.o

Comment 2

[Intermittent Failures Robot]

2 failures in 3497 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform and build breakdown:

• linux32: 1
  • debug: 1
• linux64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1780928&startday=2022-07-18&endday=2022-07-24&tree=all

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1780928 - only define CallRef if ENABLE_WASM_FUNCTION_REFERENCES is set. r=yury

This got added in bug 1774830 and defining it partially for non-Nightly
configurations breaks these.

Comment 4

[Iulian Moraru]

The patch is working in today's beta-sim.

Comment 5

[Yury Delendik (:yury)]

Attachment: Bug 1780928 - Fix WasmOpIter.cpp switch to properly handle CallRef. r?rhunt

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d83e9a9852d2
Fix WasmOpIter.cpp switch to properly handle CallRef. r=rhunt

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/25b05e354384

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9286915 [details]
Bug 1780928 - Fix WasmOpIter.cpp switch to properly handle CallRef. r?rhunt

Approved for 104.0b2

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d83e9a9852d2

Comment 10

[bszekely]

Fix verified in today's beta simulation.

Comment 11

[Intermittent Failures Robot]

10 failures in 3245 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-beta: 10

Platform and build breakdown:

• linux32: 2
  • debug: 2
• osx-cross: 2
  • debug: 2
• windows2012-64: 2
  • debug: 2
• windows2012-32: 2
  • debug: 2
• linux64: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1780928&startday=2022-07-25&endday=2022-07-31&tree=all