1781085 - Fenix release seeing an increase in null values in client_info fields

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Travis Long [:travis_]]

Starting on July 19th there was an increase in null values for client_info.device_model.

No Nimbus experiments launched at this time.

Comment 1

[Travis Long [:travis_]]

The client_info.device_model, client_info.device_manufacturer, android_sdk_version, and locale appear to have similar increases in null values, the other client_info fields appear to be fine.

Comment 2

[Travis Long [:travis_]]

Thanks to Jan-Erik for checking, but it appears that this does line up with Fenix release 103.1.0: https://github.com/mozilla-mobile/fenix/releases/tag/v103.1.0

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: pr 2131: Bug 1781085 - Add back missing client_info metrics

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1781085 - Update to Glean v50.1.3 r?chutten!

Comment 5

[Jan-Erik Rediger [:janerik]]

Above patch is against the beta branch.
Still waiting to get clarity on an appservices release before I ask for an uplift.

Comment 6

[Jan-Erik Rediger [:janerik]]

Note: fixing the same bug (and more) will be done in bug 1781030.
We thus skip the 50.1.3 release on nightly, but get the same functionality

Comment 7

[Jan-Erik Rediger [:janerik]]

Retracting what I said before (after Ryan also asked me that): we'll land this + a-s upgrade on nightly AND on beta, then we land the 51 update after that on nightly.
That avoids any weirdness in merging into beta after this cycle as both branches went through the same stages.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/581d7209c242
Update to Glean v50.1.3 r=chutten,supply-chain-reviewers

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages. CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
subprocess.CalledProcessError: Command '['cargo', 'build', '--verbose', '--frozen', '--verbose', '--features', 'headless', '--release']' returned non-zero exit status 101

Comment 10

[Jan-Erik Rediger [:janerik]]

Failed to run one more command. Pushed it again and re-landing it.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86d4da637590
Update to Glean v50.1.3 r=chutten,supply-chain-reviewers

Comment 12

[Jan-Erik Rediger [:janerik]]

Comment on attachment 9287077 [details]
Bug 1781085 - Update to Glean v50.1.3 r?chutten!

Beta/Release Uplift Approval Request

• User impact if declined: Some pieces of missing data from Glean telemetry on Android only.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minimal Glean upgrade with only the bug fix. Automated Glean tests cover it.
• String changes made/needed:
• Is Android affected?: Yes

Comment 13

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/86d4da637590

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9287077 [details]
Bug 1781085 - Update to Glean v50.1.3 r?chutten!

Approved for 104.0b3

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac14278692f6

Comment 16

[Donal Meehan [:dmeehan]]

Setting 103 to Fixed - Bug 1781823 was uplift to release, this updates release to Glean v50.1.4.
Glean v50.1.4 includes Bug 1781085 and will be released with Fenix/Focus 103.2.0