Closed Bug 1781112 Opened 2 years ago Closed 2 years ago

Do whole phrase matches for quickactions

Categories

(Firefox :: Address Bar, enhancement)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed
firefox106 --- disabled
firefox107 --- verified

People

(Reporter: daleharvey, Assigned: daleharvey)

References

Details

Attachments

(1 file)

Bug 1781112 - Enable matching full quickaction anywhere in user input. r=Standard8
48 bytes, text/x-phabricator-request
Details | Review

So for example "how to take a screenshot" matches the screenshot command

We should put this behind a pref just in case we find that it is too aggresively matching things

Assignee: nobody → dharvey
Status: NEW → ASSIGNED
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/064f6da789e7
Enable matching full quickaction anywhere in user input. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/064f6da789e7

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

Is this behind a pref?

Flags: needinfo?(dharvey)

technically there is a pref browser.urlbar.quickactions.matchInPhrase however it landed defaulted to true, the pref was implementated just in case the feature proved irritating and we wanted to roll back behaviour quickly. As long as we don't hear otherwise we can remove the pref at some point

Flags: needinfo?(dharvey)

This pref was verified during Nightly 107 feature sign-off. (feature was disabled in 105 and 106)

Status: RESOLVED → VERIFIED
status-firefox107: --- → verified

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

status-firefox106: --- → affected
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: