Open Bug 1781116 Opened 2 months ago Updated 2 days ago

QuotaManager needs to deal with SQLite path canonicalization/symlink piercing when we upgrade to 3.39

Categories

(Core :: Storage: Quota Manager, enhancement)

enhancement

Tracking

()

People

(Reporter: asuth, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

In bug 1776566 to upgrade SQLite this assertion started firing which appears to be the result of SQLite newly canonicalizing the database path(s) and implies that we should probably canonicalize any paths before handing them to SQLite on linux and OS X so that the telemetryVFS can then perform the lookup in the same canonicalized-space. Another option could be to try and rely on PROFILE/storage presumably having a consistent root, in which case we just need to be able to recognize and strip the canonicalized prefix in addition to a non-canonicalized prefix. One complication we should be aware of is that on Windows the Firefox profile can potentially exist across the roaming profile and local-machine paths, but I don't believe the windows VFS is impacted.

Note that I have not re-familiarized myself with the way the VFS/GetQuotaObject is working here (yet) so the above is hand-waving.

Assignee: nobody → jvarga

Any news on this, Jan?

Flags: needinfo?(jvarga)

Jan? Would be nice to leverage the improvements made in 3.39.x.

Jan is focusing largely on OPFS right now, tentative plan is:

  • Jan uploads his existing WIP patches to phabricator and/or via a try push that can be linked here.
  • Harveer will take a look once we have those patches up.

Clearing NI to set it again to get a rising edge. Jan should ideally set an NI on Harveer after uploading the WIPs.

Assignee: jvarga → nobody
Flags: needinfo?(jvarga)
Flags: needinfo?(jvarga)

I might actually have more time for this while I will be waiting for some OPFS reviews.

You need to log in before you can comment on or make changes to this bug.