1781204 - Asynchronous storage shutdown

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

The existing ShutdownStorage method is currently run on the IO thread only. The new asynchronous InitializeStorage method which is being added in bug 1749504 adds some members which can be accessed on the PBackground thread only. We need to reset them during shutdown, so ShutdownStorage needs to properly create an operation which runs on both threads.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1781204 - Rename ShutdownStorage to ShutdownStorageInternal; r=#dom-storage

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1781204 - Implement asynchronous ShutdownStorage; r=#dom-storage

Depends on D152724

Comment 3

[Jens Stutte [:jstutte]]

(In reply to Jan Varga [:janv] from comment #0)

The existing ShutdownStorage method is currently run on the IO thread only. The new asynchronous InitializeStorage method which is being added in bug 1749504 adds some members which can be accessed on the PBackground thread only. We need to reset them during shutdown, so ShutdownStorage needs to properly create an operation which runs on both threads.

There is (yet) no patch on bug 1749504 that would help to understand the context better? Did you invert the order of patches, adding those members here? Can you please add some more (updated) context on the patches here? Thanks

Comment 4

[Jan Varga [:janv]]

A patch for bug 1749504 is coming soon, but I guess the comment in the second patch for this bug should be enough already. Asynchronous storage shutdown makes quota manager shutdown cleaner and it paves a way for future cleanup/improvements besides supporting bug 1749504.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1781204 - Assert that directory lock for ShutdownStorageOp is acquired exclusively; r=#dom-storage

Depends on D152725

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c310be196adb
Rename ShutdownStorage to ShutdownStorageInternal; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/3aadb63489df
Implement asynchronous ShutdownStorage; r=dom-storage-reviewers,jstutte
https://hg.mozilla.org/integration/autoland/rev/f433ccad5905
Assert that directory lock for ShutdownStorageOp is acquired exclusively; r=dom-storage-reviewers,jstutte

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c310be196adb
https://hg.mozilla.org/mozilla-central/rev/3aadb63489df
https://hg.mozilla.org/mozilla-central/rev/f433ccad5905