1781209 - Swipe navigation does not work when kinetic scroll is disabled

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Jan Alexander Steffens [:heftig]]

I disable kinetic scrolling by turning off apz.gtk.kinetic_scroll.enabled, as without hold gestures, kinetic scrolling irritates me more than it helps.

Unfortunately, this also disables the swipe gestures added in bug 1539730. It would be nice if those were still available.

(Hold gestures are supported by GTK 4, but AFAIK aren't going to be backported to GTK 3.)

Comment 1

[Botond Ballo [:botond]]

Currently, kinetic scrolling is tied to our "precision" touchpad event handling codepath (touchpad scroll events are turned into PanGestureInput). Setting apz.gtk.kinetic_scroll.enabled=false disables that codepath altogether (touchpad scroll events are turned into ScrollWheelInput). Swipe navigation requires PanGestureInput events.

We could decouple the two, and have a way to take the PanGestureInput codepath without triggering a fling animation at the end of a pan gesture.

We'd probably still want to have a way for users to opt into the ScrollWheelInput codepath, as the scrolling physics are a bit different there and some users might prefer it.

cc Razvan in case this sounds interesting to you

Comment 2

[Razvan Cojocaru]

Attachment: Bug 1781209 - Swipe navigation does not work when kinetic scroll is disabled. r?botond,dlrobertson,tnikkel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4378116a135b
Swipe navigation does not work when kinetic scroll is disabled. r=botond

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4378116a135b

Comment 5

[Jan Alexander Steffens [:heftig]]

Seems to work. Thanks!

Comment 6

[Razvan Cojocaru]

Happy to help!