Remove the addition for importMapString in /testing/web-platform/tests/import-maps/resources/test-helper.js
Categories
(Core :: JavaScript Engine, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
Details
Attachments
(1 file)
As pointed out by Yulia in
https://phabricator.services.mozilla.com/D150719#inline-835527
In test-helper.js it always checks the importMapString is provided.
https://searchfox.org/mozilla-central/rev/d5edb4a4538657b7d691a41c00e6796a19ade6e7/testing/web-platform/tests/import-maps/resources/test-helper.js#111
Originally the check is for some legacy tests in V8.
https://source.chromium.org/chromium/chromium/src/+/154b398975650214a599b3aae5e8679cd18fd13c:third_party/blink/web_tests/external/wpt/import-maps/builtin-import-scheme.tentative.html;dlc=e5916b3c37418878e6e4e1e89783f18d45ec250f
But we don't have that anymore,
we could remove the import a string check.
|
Assignee | |
Comment 1•2 years ago
|
||
The check for importMapString is for legacy code from V8. 1
But we no longer have that, so we could just append the importMapString
directly.
|
||
Updated•2 years ago
|
Pushed by allstars.chh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7abab3bd2a57 Append importMapString directly in testInIframe* from test-helper.js. r=yulia
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35464 for changes under testing/web-platform/tests
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
Description
•