1781259 - 344.55 - 1.54% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 6 more (Linux, Windows) regression on Sat July 23 2022

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P3)

Description

[Andra Esanu (needinfo me)]

Perfherder has detected a build_metrics performance regression from push d1b1f300857b916411d16ef35440f3955ec6bdb8. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
345%	compiler_metrics num_static_constructors	windows-mingw32	32 clang debug	202.00 -> 898.00
343%	compiler_metrics num_static_constructors	windows-mingw32	64 clang debug	203.00 -> 899.00
79%	compiler_metrics num_static_constructors	linux64	base-toolchains-clang	204.00 -> 366.00
34%	compiler_metrics num_static_constructors	linux64	base-toolchains	328.00 -> 439.00
2%	compiler_metrics num_static_constructors	windows2012-aarch64	aarch64	192.00 -> 195.00
2%	compiler_metrics num_static_constructors	windows2012-64		193.00 -> 196.00
2%	compiler_metrics num_static_constructors	windows2012-32		195.00 -> 198.00
2%	compiler_metrics num_static_constructors	windows2012-64	fuzzing	195.00 -> 198.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Jim Mathies [:jimm]]

Guessing this is expected in which case it's wontfix. but I'll wait for :az to chime in here.

Comment 2

[az [:az]]

This does need a fix -- working on one now + aiming to have a fix out by EOD.

Comment 3

[az [:az]]

Attachment: Bug 1781259 - 344.55 - 1.54% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 6 more (Linux, Windows) regression on Sat July 23 2022 r=alwu

Remove XPCOM shutdown listener in MCSInfo, add asserts

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/637448f12f95
344.55 - 1.54% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 6 more (Linux, Windows) regression on Sat July 23 2022 r=alwu

Comment 5

[Ryan VanderMeulen [:RyanVM]]

As a general comment for the future, common practice is for the commit message to summarize what the patch is doing rather than restating the problem being fixed. Thanks!

Comment 6

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/637448f12f95

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:az, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Phabricator Automation]

Comment on attachment 9287350 [details]
Bug 1781259 - 344.55 - 1.54% compiler_metrics num_static_constructors / compiler_metrics num_static_constructors + 6 more (Linux, Windows) regression on Sat July 23 2022 r=alwu

Revision D152954 was moved to bug 1709184. Setting attachment 9287350 [details] to obsolete.

Comment 9

[az [:az]]

Took a look at this again / the perfherder graphs and reopening as there doesn't appear to be a change. I moved the earlier patch and will fix this regression as part of that work as well, aiming for Monday.

Comment 10

[Atila Butkovits]

Backed out as requested.
Backout link: https://hg.mozilla.org/integration/autoland/rev/1d796f7a78de053c8cf093b27aea69a0145e3873

Comment 11

[az [:az]]

Attachment: Bug 1781259 - Reduce static constructor overhead in MCSInfo by managing the instance with a StaticAutoPtr and moving static variable initialization to MediaCodecsSupport.cpp r=jrmuizel,kinetik

Comment 12

[az [:az]]

Adding a dependency on bug 1782837 as I've been running into errors when attempting to do mingw32 builds on try. So far I've been able to reduce the constructor count for Linux but not for Windows -- will investigate further tomorrow.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b330ef22543d
Reduce static constructor overhead in MCSInfo by managing the instance with a StaticAutoPtr and moving static variable initialization to MediaCodecsSupport.cpp r=kinetik,media-playback-reviewers

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b330ef22543d