1781765 - Incorrect color rendering on JPG image with color profile

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

A user reported over IRC that the following image renders pink on his x64/Windows machines, both Win10 and Win11:

http://www.spl80.com/magazine/wp-content/uploads/Tina-Turner-Tony-McGhee.jpg

But correctly on Firefox for ARM (Android + macOS) and all other browsers.

I cannot reproduce on mine. Investigating shows that the image contains an embedded color profile "Flextight 646 & 848".

Comment 1

[Gian-Carlo Pascutto [:gcp]]

This was reported on release and ESR, I tested Nightly.

Comment 2

[Jamie Nicol [:jnicol]]

Can you reproduce, Andrew?

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

No.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Tina-Turner-Tony-McGhee.jpg

Comment 5

[p]

Attachment: pwnt.png

Comment 6

[p]

Attachment: bork1.txt

Machine #1 (Lenovo T14 AMD, Windows 11)

Comment 7

[p]

Attachment: bork2.txt

Machine #2 (Windows Server 2019 workstation)
RDP or local display doesn't matter

Comment 8

[p]

Attachment: bork3.txt

Machine #3 (Windows 10, fresh install of Firefox made to test this)

Comment 9

[p]

Attachment: bork4.txt

Machine #4, old Intel MacBook, old Mac OS.

Comment 10

[p]

Attachment: bork5.txt

Machine #5 (MS Surface 4 Pro on Win10)

Comment 11

[p]

Saved local copy of the JPEG renders badly in Firefox too, looks good in every other program.

This JPEG does seem to have some unusual color profile information if that matters.

This bug doesn't appear random so far - every machine that did it does it every time.

Only machine where it doesn't happen is the M1 Mac.

Comment 12

[p]

08:29 <Case> ok, pink on my Win10 virtual machine too
08:30 <Case> and pink on my Win10 laptop
08:30 <Case> not pink on my Win11 desktop
08:32 <Case> aha, pink on a clean profile with Win11 too
08:33 <Case> so it's some setting I have adjusted that fixes it on my main profile
08:36 <Case> gfx.color_management.enablev4
08:36 <Case> that defaults to false. Set to true and it works
08:39 <Case> that's an about:config flag if you aren't familiar with the full config system

Comment 13

[Gian-Carlo Pascutto [:gcp]]

https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#5367

That explains why we couldn't repro on Nightly or why it works on macOS.

Comment 14

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Comment #13 is about gfx.color_management.native_srgb: https://searchfox.org/mozilla-central/rev/ac4d655d24eb0689147702d20e68b5f5ecde7af7/modules/libpref/init/StaticPrefList.yaml#5364-5371

Comment 15

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Actually the pref mentioned in comment #12 is gfx.color_management.enablev4 which is shipped by https://phabricator.services.mozilla.com/D159527. I can confirm that the image now doesn't seem pink but disabling that pref makes it pink. So I guess this is now fixed.