1781798 - Flashes of black while quickly moving mouse over the "network load" markers/identifiers on profiler page(Was:Flashes of black on the Profiler page while keeping the key pressed)

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

1. Enable gpu-canvas
2. Open any profile, example :https://share.firefox.dev/3zdZ5Tl
3. Go to the main thread, and press-and-hold the right key that will drill-down the stack line by line

ER: Flashes of black
AR: Not so

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Attachment: bandicam 2022-07-27 19-52-04-968.mp4

Comment 3

[Mayank Bansal]

Easier to repro with this profile: https://share.firefox.dev/3vqenTN

Just quickly hover over the network markers/bars in the "Call tree" tab.

Comment 4

[Mayank Bansal]

2022-07-28T20:27:32.926000: DEBUG : Found commit message:
Bug 1763370 - Explicitly delete WebGL textures in DrawTargetWebgl. r=aosmond,gfx-reviewers

It seems that client WebGL textures get GC'd way later than is really useful,
so we need to ensure that we explicitly delete WebGL textures to ensure that
it happens in a timely fashion.

Differential Revision: https://phabricator.services.mozilla.com/D146277

2022-07-28T20:27:32.926000: DEBUG : Did not find a branch, checking all integration branches
2022-07-28T20:27:32.931000: INFO : The bisection is done.
2022-07-28T20:27:32.931000: INFO : Stopped

Comment 5

[Mayank Bansal]

You also get the following messages on the log :

2022-07-28T20:26:22.451000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x88760873'
2022-07-28T20:26:22.455000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x88760873'
2022-07-28T20:26:22.617000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x80070057'
2022-07-28T20:26:22.620000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x80070057'
2022-07-28T20:26:22.934000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x80070057'
2022-07-28T20:26:22.938000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x80070057'
2022-07-28T20:26:22.985000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x80070057'
2022-07-28T20:26:22.985000: INFO : b'[GFX1-]: RenderDXGITextureHost Failed to open shared texture, hr=0x80070057'

Comment 6

[Mayank Bansal]

Attachment: STR.mp4

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1763370

Comment 8

[Lee Salzman [:lsalzman]]

I can't reproduce this on Linux. This is seemingly only happening on Windows, which doesn't really support accelerated canvas2d yet. Marking this as S4.

Comment 9

[Mayank Bansal]

bug 1544434 is probably a dupe.

Comment 10

[Mayank Bansal]

Cant repro this anymore.
Mozregression points to :
Bug 1789658 - Keep gl::SharedSurface/TextureData alive if remote texture's TextureHost is still in use by WebRender r=lsalzman

Differential Revision: https://phabricator.services.mozilla.com/D156774