1782003 - Code for setting lastProfilingFrame in GeckoProfilerRuntime::enable is wrong

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Jan de Mooij [:jandem]]

The code in GeckoProfilerRuntime::enable is incorrect when the top activation is a C++ interpreter activation: in that case lastProfilingFrame will be set to nullptr, which we then use for the first JitActivation. This doesn't make sense.

I noticed this while looking at this code for bug 1780547, but I'm not sure if this bug is causing that issue.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1782003 - Set lastProfilingFrame correctly in GeckoProfilerRuntime::enable. r?iain!

If the top activation is a C++ interpreter activation, the code would incorrectly use
nullptr as lastProfilingFrame for the first JitActivation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1364520

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae3796648dd4
Set lastProfilingFrame correctly in GeckoProfilerRuntime::enable. r=iain

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ae3796648dd4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jandem, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox104 to wontfix.

For more information, please visit auto_nag documentation.