1782087 - Create registration doorhanger for IdentityCredential

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, enhancement, P1)

Description

[Benjamin VanderSloot [:bvandersloot]]

see https://fedidcg.github.io/FedCM/#request-consent-to-sign-up

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1782087, part 1 - Create registration doorhanger for IdentityCredential, r=pbz!

We need one more panel in the doorhanger- one that is a user information panel per (rp, idp, account) tuple.

This just gives the privacy policy and ToS links to the user. It is implemented similarly to the other panels,
and would similarly be updated by Bug 1800695.

Similar to the original doorhanger patch (Bug 1782088 - Create account chooser doorhanger for IdentityCredential)
tests and fine polish are out of scope for this prototype.

Depends on D162125

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1782087, part 2 - Platform changes to use the doorhanger, r=timhuang!

This patch integrates the doorhanger into the CreateCredential promise chain,
and in doing so added a few new helper functions PromptUserWithPolicy and FetchMetadata.

FetchMetadata is almost identical to the other Fetch* functions in this file.
PromptUserWithPolicy is a sllight variation on the other doorhanger-creating funcitons.

I updated the tests to pass by adding a new endpoint with the right headers and a static json file

Depends on D162126

Comment 3

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for xpcshell failures on test_forget_about_site_security_headers.js
Failure log for mochitest plain chrashes
Failure log for bc failures on browser_394759_purge.js related to ForgetAboutSite.jsm
also there are multiple TV failures on test_identity_credential_storage_service.js

Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c7764e1ff1d
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/66eeced8dbed
part 2 - Platform changes to use the doorhanger, r=timhuang

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8031bd99e17d
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/a06b230dc4f2
part 2 - Platform changes to use the doorhanger, r=timhuang

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing multiple mozStorageService related failures

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/372252b98cd7
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/955c8cad8112
part 2 - Platform changes to use the doorhanger, r=timhuang

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in toolkit/components/cleardata/tests/browser/browser_quota.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6577d5920c698d8aac2e77d3cc6fc249d4d4702

Push with failures

Failure log

INFO - Buffered messages finished
[task 2022-12-02T22:26:25.361Z] 22:26:25     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/cleardata/tests/browser/browser_quota.js | 16777216 == 0 - JS frame :: chrome://mochitests/content/browser/toolkit/components/cleardata/tests/browser/browser_quota.js :: runTest/</< :: line 98
[task 2022-12-02T22:26:25.361Z] 22:26:25     INFO - Stack trace:

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d21fdf144f62
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/6d39ec6dcc15
part 2 - Platform changes to use the doorhanger, r=timhuang

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d21fdf144f62
https://hg.mozilla.org/mozilla-central/rev/6d39ec6dcc15