Closed Bug 1782087 Opened 6 months ago Closed 2 months ago

Create registration doorhanger for IdentityCredential

Categories

(Core :: DOM: Credential Management, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: bvandersloot, Assigned: bvandersloot)

References

Details

Attachments

(2 files)

No longer blocks: 1782085
Depends on: 1782085
Blocks: 1782066

We need one more panel in the doorhanger- one that is a user information panel per (rp, idp, account) tuple.

This just gives the privacy policy and ToS links to the user. It is implemented similarly to the other panels,
and would similarly be updated by Bug 1800695.

Similar to the original doorhanger patch (Bug 1782088 - Create account chooser doorhanger for IdentityCredential)
tests and fine polish are out of scope for this prototype.

Depends on D162125

Assignee: nobody → bvandersloot
Status: NEW → ASSIGNED

This patch integrates the doorhanger into the CreateCredential promise chain,
and in doing so added a few new helper functions PromptUserWithPolicy and FetchMetadata.

FetchMetadata is almost identical to the other Fetch* functions in this file.
PromptUserWithPolicy is a sllight variation on the other doorhanger-creating funcitons.

I updated the tests to pass by adding a new endpoint with the right headers and a static json file

Depends on D162126

Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c7764e1ff1d
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/66eeced8dbed
part 2 - Platform changes to use the doorhanger, r=timhuang
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8031bd99e17d
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/a06b230dc4f2
part 2 - Platform changes to use the doorhanger, r=timhuang

Backed out for causing multiple mozStorageService related failures

Backout link

Push with failures

Failure log

Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/372252b98cd7
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/955c8cad8112
part 2 - Platform changes to use the doorhanger, r=timhuang

Backed out for causing bc failures in toolkit/components/cleardata/tests/browser/browser_quota.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6577d5920c698d8aac2e77d3cc6fc249d4d4702

Push with failures

Failure log

INFO - Buffered messages finished
[task 2022-12-02T22:26:25.361Z] 22:26:25     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/cleardata/tests/browser/browser_quota.js | 16777216 == 0 - JS frame :: chrome://mochitests/content/browser/toolkit/components/cleardata/tests/browser/browser_quota.js :: runTest/</< :: line 98
[task 2022-12-02T22:26:25.361Z] 22:26:25     INFO - Stack trace:
Pushed by bvandersloot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d21fdf144f62
part 1 - Create registration doorhanger for IdentityCredential, r=pbz,fluent-reviewers,webidl,smaug,flod
https://hg.mozilla.org/integration/autoland/rev/6d39ec6dcc15
part 2 - Platform changes to use the doorhanger, r=timhuang
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Flags: needinfo?(bvandersloot)
You need to log in before you can comment on or make changes to this bug.