Closed
Bug 1782254
Opened 2 years ago
Closed 2 years ago
Add telemetry to measure the number of times users had an interaction with the editing feature
Categories
(Firefox :: PDF Viewer, enhancement)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
105 Branch
Tracking | Status | |
---|---|---|
firefox105 | --- | fixed |
People
(Reporter: marco, Assigned: calixte)
References
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Updated•2 years ago
|
Summary: Add telemetry to measure the number of times users use the ink button to draw → Add telemetry to measure the number of times users had an interaction with the editing feature
Assignee | ||
Comment 2•2 years ago
|
||
We want to add some telemetry to try to understand how users are using the editing feature in pdf.js.
We'd like to have an answer to the following questions:
- How often the “ink” button is clicked ?
- How often the “draw” button is clicked ?
- How often a PDF is saved after editing ?
- How often a PDF is printed after editing ?
Assignee | ||
Comment 3•2 years ago
|
||
Attachment #9288100 -
Flags: data-review?(tlong)
Comment 4•2 years ago
|
||
Comment on attachment 9288100 [details]
data_collection_request.txt
Data Review
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, through the probe definition files and the Probe Dictionary. Also, documented via this public bug.
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, through the standard telemetry preference in the application settings.
- If the request is for permanent data collection, is there someone who will monitor the data over time?
N/A, collection to end in Firefox version 113
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 2: Interaction data
- Is the data collection request for default-on or default-off?
Default-on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does the data collection use a third-party collection tool?
No
Result
data-review+
Attachment #9288100 -
Flags: data-review?(tlong) → data-review+
Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Comment 6•2 years ago
|
||
Pushed by cdenizet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0794c953b2f4
Add some telemetry to measure how often users are using the pdf editing feature r=Dexter
Comment 8•2 years ago
|
||
Backed out for causing failures on browser_pdfjs_editing_telemetry.js
- backout: https://hg.mozilla.org/integration/autoland/rev/f13a3994e2978367c132857c486198c6d9bfc22a
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=0794c953b2f44ee077a5d320261b6672313c0f0d
- push where tier 1 fail was seen: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=fc1e55745c43ef00123caaf70c91e324c0068039&selectedTaskRun=OlkdQgviT4SV25Ws8YdesQ.0
- failure log: https://treeherder.mozilla.org/logviewer?job_id=386766269&repo=autoland&lineNumber=56097
[task 2022-08-09T11:26:06.580Z] 11:26:06 INFO - TEST-PASS | toolkit/components/pdfjs/test/browser_pdfjs_editing_telemetry.js | 1 == 1 -
[task 2022-08-09T11:26:06.580Z] 11:26:06 INFO - Buffered messages finished
[task 2022-08-09T11:26:06.580Z] 11:26:06 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/browser_pdfjs_editing_telemetry.js | Uncaught exception in test - undefined - timed out after 50 tries.
[task 2022-08-09T11:26:06.580Z] 11:26:06 INFO - Leaving test bound test
[task 2022-08-09T11:26:06.581Z] 11:26:06 INFO - GECKO(7176) | MEMORY STAT | vsize 8031MB | residentFast 386MB | heapAllocated 123MB
[task 2022-08-09T11:26:06.581Z] 11:26:06 INFO - TEST-OK | toolkit/components/pdfjs/test/browser_pdfjs_editing_telemetry.js | took 12478ms
[task 2022-08-09T11:26:06.582Z] 11:26:06 INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-08-09T11:26:06.582Z] 11:26:06 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pdfjs/test/browser_pdfjs_editing_telemetry.js | Found an unexpected tab at the end of test run: http://example.com/browser/toolkit/components/pdfjs/test/file_pdfjs_test.pdf -
Flags: needinfo?(cdenizet)
Assignee | ||
Comment 9•2 years ago
|
||
The issue is only on mac because the test is using ctrl+c/v keys to copy/paste an editor and on mac we must use meta instead of ctrl.
Flags: needinfo?(cdenizet)
Comment 10•2 years ago
|
||
Pushed by cdenizet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50f6400d04bf
Add some telemetry to measure how often users are using the pdf editing feature r=Dexter
Comment 11•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•