1782325 - [hazards] Improve error message when MOZCONFIG is set while running the hazard analysis

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Steve Fink [:sfink] [:s:]]

Right now, if you run mach hazards gather with MOZCONFIG set to something that doesn't closely match js/src/devtools/rootAnalysis/mozconfig.{js,browser}, you'll get a wall of text that you have to sift through to find the real error message.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1782325 - mach hazards gather: validate the mozconfig eagerly

Comment 2

[Steve Fink [:sfink] [:s:]]

Note that the purpose of allowing MOZCONFIG to be set at all is because you might want to analyze the code with a nonstandard configuration.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

It's reviewed and ready to land. I'll leave it to :sfink to land.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d861fa7c9a4e
mach hazards gather: validate the mozconfig eagerly r=firefox-build-system-reviewers,ahochheiden

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d861fa7c9a4e