Closed Bug 1782450 Opened 2 years ago Closed 2 years ago

Update SMDOC for environment object

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox106 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The Environment Objects SMDOC summarizes the environments for each case, but it's not up to date

https://searchfox.org/mozilla-central/rev/92e8568bbe7c8bf64f7a8ee958291877d960d7d8/js/src/vm/EnvironmentObject.h#46

* [SMDOC] Environment Objects
Blocks: SMDOC
Severity: -- → N/A
Priority: -- → P1
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/eb01cc5511fc
Update comment for EnvironmentObject.h and add testcases for non-syntactic scope. r=tcampbell
Regressions: 1787244
Flags: needinfo?(arai.unmht)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(tcampbell)
Flags: needinfo?(arai.unmht)
Flags: needinfo?(tcampbell)
Flags: needinfo?(arai.unmht)

So far, I disabled almost all part of the testcase, and still it hits unknown failure without the newly added functions called.
but it doesn't fail if I remove more.
I'll investigate more to see which part of the testcase is causing the issue.

fail: https://treeherder.mozilla.org/jobs?repo=try&revision=09db3ff9ad7e9cc02c60be33f969b4a676aceca5
pass: https://treeherder.mozilla.org/jobs?repo=try&revision=afde30b59347be5826d0e2607584c8ca1827607b

it turns out that clicking the button inside the form triggers navigation and it results in infinite reload.

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/a8be9ab374f4
Update comment for EnvironmentObject.h and add testcases for non-syntactic scope. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: