1782450 - Update SMDOC for environment object

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

The Environment Objects SMDOC summarizes the environments for each case, but it's not up to date

https://searchfox.org/mozilla-central/rev/92e8568bbe7c8bf64f7a8ee958291877d960d7d8/js/src/vm/EnvironmentObject.h#46

* [SMDOC] Environment Objects

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1782450 - Update comment for EnvironmentObject.h and add testcases for non-syntactic scope. r?tcampbell!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb01cc5511fc
Update comment for EnvironmentObject.h and add testcases for non-syntactic scope. r=tcampbell

Comment 3

[Atila Butkovits]

Backed out for causing Bug 1787244. (as requested).

Backout link: https://hg.mozilla.org/integration/autoland/rev/1f48a06f24dcd6a2e1b731bf2fa688647df11380

Comment 4

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[Tooru Fujisawa [:arai]]

So far, I disabled almost all part of the testcase, and still it hits unknown failure without the newly added functions called.
but it doesn't fail if I remove more.
I'll investigate more to see which part of the testcase is causing the issue.

fail: https://treeherder.mozilla.org/jobs?repo=try&revision=09db3ff9ad7e9cc02c60be33f969b4a676aceca5
pass: https://treeherder.mozilla.org/jobs?repo=try&revision=afde30b59347be5826d0e2607584c8ca1827607b

Comment 6

[Tooru Fujisawa [:arai]]

it turns out that clicking the button inside the form triggers navigation and it results in infinite reload.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8be9ab374f4
Update comment for EnvironmentObject.h and add testcases for non-syntactic scope. r=tcampbell

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a8be9ab374f4