1782578 - Implement a context menu modal for text recognition

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Greg Tatum [:gregtatum]]

Figma spec

For the initial text recognition in images implementation, we are going with a modal that displays the text. This is triggered via a context menu.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1782578 - Put the img shadow DOM behind a preference r?nordzilla

This code will most likely be removed, but for now I am putting it
behind a pref so that it won't be activated when the modal is being
created.

See Bug 1782582 for the removal of the code.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1782578 - Rename and move the context menu for text recognition r?nordzilla

This matches what is in the Figma spec.

Depends on D153393

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1782578 - Stub out the textrecognition component files r?nordzilla

The implementation follows after this, but I felt it made the code
easier to read to by splitting it out.

Depends on D153394

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1782578 - Build out the text recognition modal r?nordzilla,morgan

This patch contains the bulk of the implementation of the modal. Most of
it is UI work and wiring together the various components. There is a bit
of complexity in the clustering algorithm, as I implemented the DBSCAN
algorithm to help cluster the text recognition results.

I filed Bug 1782586 to improve the DBSCAN algorithm, but currently it
works the same as the algorithm is described on Wikipedia.

Note that the tests are in the following patch in order to keep the line
count small for this patch.

Depends on D153395

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1782578 - Add tests for the text recognition modal r?nordzilla

Depends on D153396

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8332d678079e
Put the img shadow DOM behind a preference r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/98d0d6bcd37b
Rename and move the context menu for text recognition r=nordzilla,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/b4c51d1ffa99
Stub out the textrecognition component files r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/4f969d46dd37
Build out the text recognition modal r=nordzilla,fluent-reviewers,Jamie,flod
https://hg.mozilla.org/integration/autoland/rev/5f17ee4cc4df
Add tests for the text recognition modal r=nordzilla

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on browser_parsable_css.js

Backout link

Push with failures

Failure log // Failure log 2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a77a405173ff
Put the img shadow DOM behind a preference r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/7dac35a8d6de
Rename and move the context menu for text recognition r=nordzilla,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/3e858b2ed1c5
Stub out the textrecognition component files r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/e183536cb8d9
Build out the text recognition modal r=nordzilla,fluent-reviewers,Jamie,flod
https://hg.mozilla.org/integration/autoland/rev/ee4685a4e583
Add tests for the text recognition modal r=nordzilla

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a77a405173ff
https://hg.mozilla.org/mozilla-central/rev/7dac35a8d6de
https://hg.mozilla.org/mozilla-central/rev/3e858b2ed1c5
https://hg.mozilla.org/mozilla-central/rev/e183536cb8d9
https://hg.mozilla.org/mozilla-central/rev/ee4685a4e583