1782585 - (wasm-multi-memory) Implement multi-memory proposal

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt]]

Implement the multi-memory proposal.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Add multi-memory feature flag. r?jseward

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize validation to multiple memories. r?jseward

Depends on D170977

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize Instance to multiple memories. r?jseward

Depends on D170978

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: WIP: Bug 1782585 - wasm: Remove omitBoundsChecks.

Depends on D170979

Comment 5

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Let active data segments specify multiple memories. r?jseward

Depends on D170980

Comment 6

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize memory.size and memory.grow for multiple memories. r?jseward

Depends on D170981

Comment 7

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize memory.fill for multiple memories. r?jseward

Depends on D170982

Comment 8

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize memory.init for multiple memories. r?jseward

Depends on D170983

Comment 9

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize memory.copy for multiple memories. r?jseward

Depends on D170984

Comment 10

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize load/store instructions for multiple memories. r?jseward

Depends on D170985

Comment 11

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Import multi-memory spec tests. r?jseward

Depends on D170986

Comment 12

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Update error messages in tests for bad index. r?jseward

Depends on D170987

Comment 13

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Generalize memory.discard for multiple memories. r?jseward

This commit generalizes validation and execution of memory.discard
to be able to use non-zero memories.

Depends on D170985

Comment 14

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Decode I32 limits as varU32. r?yury

A multi-memory spec test adds an assertion that we do not
decode more bytes than possible to fit in an i32 limit.

Depends on D171023

Comment 15

[Ryan Hunt [:rhunt]]

Attachment: Bug 1782585 - wasm: Cleanup instance data for multi-memory. r?yury

• Rename the first two fields of Instance to specify they are only
  for memory 0
  • Rename MemoryInstanceData::memoryBase to 'base' to be less redundant and
    match the Instance::memory0Base field
  • Use allocateInstanceDataBytesN for memory instance data

Depends on D178559

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:rhunt, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e9f10a24170
wasm: Add multi-memory feature flag. r=jseward
https://hg.mozilla.org/integration/autoland/rev/b0ca19fa93a7
wasm: Generalize validation to multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/c4922e51fe53
wasm: Generalize Instance to multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/587ec45047a7
wasm: Let active data segments specify multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/8d81c8737512
wasm: Generalize memory.size and memory.grow for multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/2bbad33c3331
wasm: Generalize memory.fill for multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/1c2a75aa8eb0
wasm: Generalize memory.init for multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/0123fad4d87a
wasm: Generalize memory.copy for multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/33cdd2b0520b
wasm: Generalize memory.discard for multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/472b79690226
wasm: Generalize load/store instructions for multiple memories. r=jseward
https://hg.mozilla.org/integration/autoland/rev/d76be145040e
wasm: Import multi-memory spec tests. r=jseward
https://hg.mozilla.org/integration/autoland/rev/96e5b38b9f3e
wasm: Update error messages in tests for bad index. r=jseward
https://hg.mozilla.org/integration/autoland/rev/0ac5a0f4a53c
wasm: Decode I32 limits as varU32. r=yury
https://hg.mozilla.org/integration/autoland/rev/bd073b885af3
wasm: Cleanup instance data for multi-memory. r=yury
https://hg.mozilla.org/integration/autoland/rev/728f4a4d08f5
apply code formatting via Lando

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1e9f10a24170
https://hg.mozilla.org/mozilla-central/rev/b0ca19fa93a7
https://hg.mozilla.org/mozilla-central/rev/c4922e51fe53
https://hg.mozilla.org/mozilla-central/rev/587ec45047a7
https://hg.mozilla.org/mozilla-central/rev/8d81c8737512
https://hg.mozilla.org/mozilla-central/rev/2bbad33c3331
https://hg.mozilla.org/mozilla-central/rev/1c2a75aa8eb0
https://hg.mozilla.org/mozilla-central/rev/0123fad4d87a
https://hg.mozilla.org/mozilla-central/rev/33cdd2b0520b
https://hg.mozilla.org/mozilla-central/rev/472b79690226
https://hg.mozilla.org/mozilla-central/rev/d76be145040e
https://hg.mozilla.org/mozilla-central/rev/96e5b38b9f3e
https://hg.mozilla.org/mozilla-central/rev/0ac5a0f4a53c
https://hg.mozilla.org/mozilla-central/rev/bd073b885af3
https://hg.mozilla.org/mozilla-central/rev/728f4a4d08f5