1782638 - When dragging a bookmark towards a bookmarks bar sub-subfolder list, the list closes itself before drop

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[dakwamine]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

(Tested on Windows 11.)

1. Open Firefox.
2. Display the bookmarks bar.
3. Create a folder in this bar labeled "Folder".
4. Create a subfolder labeled "Folder with incredibly long name because why not, don't you think?".
5. Go to any web page.
6. Drag the tab of the current page onto the folder item.
7. Drag the tab onto the subfolder item.
8. Drop the tab. => The page is bookmarked.
9. Repeat 6.
10. Repeat 7.
11. Drag the tab over the list of the subfolder.

Additional info

It also happens when, instead of a long folder name, there is a long bookmark label in the folder list. In my understanding, the issue is related to the ellipsis handling on long labels.

Actual results:

The subfolder list closes when moving the mouse cursor onto it, preventing me from dropping my tab in it.

Expected results:

The subfolder list keeps itself open when moving the mouse cursor onto it.

Comment 1

[dakwamine]

As a user with 3 levels deep bookmark tree, it became difficult to use the bookmarks bar. This bug did not occur on previous Firefox versions (<103).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[dakwamine]

I found that this issue happens less often on my weaker laptop. It may be because it's Windows 10, or because it is a much lower specs than my main PC (a little laggy).

Comment 4

[Marco Bonardo [:mak]]

I found through mozregression that this was regressed by bug 1772507... Though this is somehow intermittent, sometimes it works, most of the times it doesn't, not sure what is causing the changed behavior.

Comment 5

[Marco Bonardo [:mak]]

Attachment: folder_drag.gif

Comment 6

[Marco Bonardo [:mak]]

Emilio, any thoughts or ideas?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1772507

Comment 8

[Donal Meehan [:dmeehan]]

Setting 103 as fix-optional, pending the result of the ni for investigation,
:emilio/:mak could you also please set a severity rating?

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782638 - For beta: Remove input region in bookmark popups. r=mak

This is a more minimal fix to restore previous behavior.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1782638 - Simplify styling of bookmarks toolbar submenus. r=mak

Also, align them properly.

The issue is that we inherit the region margin introduced in bug 1772507, but
we were styling the panel in a way that causes the region to not match the
shadow size.

Simplify a bit the styling so that all the margins add up.

For uplift it'd be simpler to just set the new property to zero, I'll prepare a
patch for that. That would cause the shadows to count as popup contents, but
that's the pre-103 behavior which seems fine.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9288632 [details]
Bug 1782638 - For beta: Remove input region in bookmark popups. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 / etc.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Single line CSS change
• String changes made/needed: none
• Is Android affected?: Yes

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9288633 [details]
Bug 1782638 - Simplify styling of bookmarks toolbar submenus. r=mak

This one is not intended for uplift.

Comment 13

[Marco Bonardo [:mak]]

Attachment: screenshot

There is some problem with the position of the drop indicator with the patch, likely just missing margin/padding.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Hey look, that's a pre-existing issue on Linux! Will fix.

Comment 15

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9288632 [details]
Bug 1782638 - For beta: Remove input region in bookmark popups. r=mak

Approved for 104.0b8

Comment 16

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

https://hg.mozilla.org/releases/mozilla-beta/rev/58319bfb35d9

Comment 17

[Monica Chiorean]

Reproduced the issue on Win10 using FF build 103.0.
Verified main issue(bookmark) is fixed on Win10/Mac10.13/Ubuntu 20.4 using Beta 104.0b8 (20220809195844) .
But issue mentioned on comment#13 is still reproducing on Ubuntu 20.4. Will this issue be fixed on this bug? or is there a separate tracking issue? Thank you.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48baf52b5d6
Simplify styling of bookmarks toolbar submenus. r=mak

Comment 19

[Emilio Cobos Álvarez (:emilio)]

Yes, it will get fixed on this bug, but not on beta, because it's more risky.

Comment 20

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c48baf52b5d6

Comment 21

[Monica Chiorean]

Verified as fixed the indicator issue on latest Nightly 105.0a1(20220810212956) on Ubuntu20.4 (also checked that is working as expected on Win10/Mac10.13). Marking issue as fixed on 105 for this issue. Thank you Emilio for clarifying that.