1782740 - Tracking the update to NSPR 4.34.1 (correctness fixes)

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Kai Engert [:KaiE:]]

I'd like to fix one or two correctness issues in NSPR. There haven't been any changes to NSPR after the release of 4.34 yet, so doing a 4.34.1 release seems best.

Comment 1

[Kai Engert [:KaiE:]]

NSPR_4_34_1_BETA1 tagged, decided to include bug 1760611, only.

Testing that NSPR works with NSS test suite:
https://treeherder.mozilla.org/jobs?repo=nss&revision=6d025c93055451074cf975089701faf3f221e519

Testing that NSPR works with Firefox:
https://treeherder.mozilla.org/jobs?repo=try&revision=581456b306cb4b029f86b3ffed0478bc8ccc7f72

If all good, I'll release NSPR 4.34.1 today.

Comment 2

[Kai Engert [:KaiE:]]

(In reply to Kai Engert (:KaiE:) from comment #1)

Testing that NSPR works with Firefox:
https://treeherder.mozilla.org/jobs?repo=try&revision=581456b306cb4b029f86b3ffed0478bc8ccc7f72

Ryan, that one produced "271 possible regressions".

I somehow don't believe this commit caused all those regressions. Is that the normal amount of test failures?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

At a very cursory glance, it looks like a lot of test suites were run which don't actually run in our normal CI (compare to https://treeherder.mozilla.org/jobs?repo=mozilla-central). Looks like a lot of known intermittents otherwise. If in doubt, you can always ask in the #sheriffs channel in Matrix as well - they'll have more experience with "normal" levels of intermittents these days :)

Comment 4

[Kai Engert [:KaiE:]]

The updated try build, using parameters recommended by sheriffs, still has 72 failures. But all failures appear to link to intermittent bugs. I think the patch should be fine.

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Bug 1782740 - Update to NSPR 4.34.1 RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3962f6147162
Update to NSPR 4.34.1 RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3962f6147162

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta & ESR102 approval when you get a chance.

Comment 9

[Kai Engert [:KaiE:]]

Comment on attachment 9288557 [details]
Bug 1782740 - Update to NSPR 4.34.1 RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE

Beta/Release Uplift Approval Request

• User impact if declined: none
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple correctness/bounds check
• String changes made/needed:
• Is Android affected?: Unknown

Comment 10

[Kai Engert [:KaiE:]]

Comment on attachment 9288557 [details]
Bug 1782740 - Update to NSPR 4.34.1 RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: fixes sec-high bug 1760611
• User impact if declined: none
• Fix Landed on Version: 102
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): simple bounds checking fix

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9288557 [details]
Bug 1782740 - Update to NSPR 4.34.1 RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE

Approved for 104.0b8

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3dab417365ed

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9288557 [details]
Bug 1782740 - Update to NSPR 4.34.1 RTM. r=bbeurdouche UPGRADE_NSPR_RELEASE

Approved for 102.2esr.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/9e10397c8a15